Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove static analysis builds because they're running out of disk space. #2096

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

miniksa
Copy link
Member

@miniksa miniksa commented Jul 25, 2019

@DHowett-MSFT has a thread with the relevant people trying to sort this whole thing out.

But in the meantime, the static analysis builds are low value and are blocking actual work from happening.

So I commented them out for now.

Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall I be the guy? Want to whack a TODO and a followup issue to re-enable these?

@adiviness
Copy link
Contributor

This is annoying to see.

@miniksa
Copy link
Member Author

miniksa commented Jul 25, 2019

This is annoying to see.

I know, but I need to merge things today. I want to get them back online.

@miniksa
Copy link
Member Author

miniksa commented Jul 25, 2019

Shall I be the guy? Want to whack a TODO and a followup issue to re-enable these?

Yes, I'll write one.

@adiviness
Copy link
Contributor

This is annoying to see.

I know, but I need to merge things today. I want to get them back online.

I understand. I approved but it doesn't hold the same weight it used to. You'll need a real 2nd approver.

@miniksa miniksa merged commit 8ae4f2f into master Jul 25, 2019
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 26, 2019
@miniksa miniksa deleted the dev/miniksa/bye_static_analysis branch January 28, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants