Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json settings documentation #2699

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Fix json settings documentation #2699

merged 2 commits into from
Sep 10, 2019

Conversation

fredimachado
Copy link
Contributor

@fredimachado fredimachado commented Sep 9, 2019 •
edited
Loading

The ctrl+c issue was fixed in #2446

Release: Windows Terminal Preview v0.4.2382.0

@fredimachado
Copy link
Contributor Author

I could have changed the text to this:

Note: If you set your copy keybinding to "ctrl+c", you'll only be able to send an interrupt to the commandline application using Ctrl+C when there's no text selection.

Thoughts?

@zadjii-msft
Copy link
Member

Note: If you set your copy keybinding to "ctrl+c", you'll only be able to send an interrupt to the commandline application using Ctrl+C when there's no text selection.

I definitely prefer that text.

I'd also leave the note about Ctrl+V, because that's still relevant.

@DHowett-MSFT
Copy link
Contributor

Yeah, I like the text change. Ctrl+V is also still worth calling out. Thanks for working on our docs!

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 9, 2019
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 9, 2019
@fredimachado
Copy link
Contributor Author

@zadjii-msft @DHowett-MSFT: Updated!

Thanks

@miniksa
Copy link
Member

miniksa commented Sep 10, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@miniksa miniksa merged commit 2da3b49 into microsoft:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa miniksa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fredimachado @zadjii-msft @DHowett-MSFT @miniksa @carlos-zamora