Add a splitPane option to duplicate current profile

[surya-prakash-susarla]

This change adds the ability to configure a pane to split by duplicating the current profile

Closes #1756

[zadjii-msft]

I'd really love if we could add some tests for scenarios using this setting as well :)

Overall I'm pretty happy with this. I think with the few pieces you're missing, this will be easy to sign off on

[zadjii-msft]

@msftbot make sure @DHowett-MSFT signs off on this

[ghost]

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I'll only merge this pull request if it's approved by @DHowett-MSFT

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

[zadjii-msft]

This looks good to me. Thanks!

[surya-prakash-susarla]

@zadjii-msft Hey, sorry to disturb again but I'm still not able to deploy it to test my changes. The 'bcz' command gives me a couple of warnings but says that the build succeeded. When I try to deploy the solution though I run into different kinds of errors. Can you please help me out on testing this.
[The below error came up when I used deploy solution in VS]

[The same error comes up when I press f5 directly to debug too]

[zadjii-msft]

@Surya-06 I've frankly never seen that error before D: I'm not sure how that'd even happen... Does E:\terminal\scr\cascadia\TerminalControl\Generated Files\SearchBoxControl.xaml actually exist?

Maybe try just building the solution directly from VS, then running it there? There's pretty minor differences between how VS builds the solution and how plain-old MsBuild (which bcz calls) builds it. That's my only theory at the moment.

I'll pull your branch locally to test myself and make sure.

[zadjii-msft]

Okay, checked this out and built this locally. The suggestion I've made is needed to prevent a runtime exception. Without this line, it's possible that realGuid is never initialized. Fix that, and you'll be good to go.

[surya-prakash-susarla]

@zadjii-msft I have committed your suggestion to handle the exception you pointed out. Let me know if I've missed anything.

[surya-prakash-susarla]

@zadjii-msft Hey, I've finally been able to deploy and run the terminal. Is the key that I created enough to create a keyboard shortcut? If not is there a guide on how to create the shortcuts.

[zadjii-msft]

@Surya-06 yep, it works just fine for me :)

[surya-prakash-susarla]

@Surya-06 yep, it works just fine for me :)

can you tell me how you added the keyboard shortcut. i tried action as splitPane with splitMode as arg, i tried the value as 0/1 and also "duplicate" but couldn't see the result.

[zadjii-msft]

No problem, I just threw it on:

        { "command": { "action": "splitPane", "split":"auto", "splitMode": "duplicate" }, "keys": [ "ctrl+alt+t" ] },

[surya-prakash-susarla]

@zadjii-msft Finally everything fell into place on my machine and I could use my changes. Thanks for all the help. Hope to contribute more!!! 😃
PS: For anyone facing build errors, this video is super awesome. https://www.youtube.com/watch?v=4N1Ils4cDYo

[surya-prakash-susarla]

@DHowett @carlos-zamora @miniksa @leonMSFT Can any of you please take a look at this, it's been a week since the last review. Thanks !

[miniksa]

Yeah, sure. Though I'm not sure why @zadjii-msft requested @DHowett-MSFT for sign-off. I'll confer with him about it.

[miniksa]

OK, I approve. It looks good. But @zadjii-msft said that he and @DHowett-MSFT had a verbal discussion about this, so I want to prod @DHowett-MSFT to be final check before it merges. I'll bother him today.

[miniksa]

@msftbot make sure @DHowett-MSFT signs off on this

[ghost]

Hello @miniksa!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I'll only merge this pull request if it's approved by @DHowett-MSFT

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

[surya-prakash-susarla]

@miniksa Thanks for the quick reply. Do let me know if something needs to be done.

[DHowett-MSFT]

If your branch has maintainer access turned on, I'm going to push a commit that fixes the line endings making it difficult to review/making everything conflict w/ ActionAndArgs

[DHowett-MSFT]

This looks great to me. Thanks!

[DHowett-MSFT]

(Sorry we sat on a relatively well-contained change for two weeks!)

[surya-prakash-susarla]

(Sorry we sat on a relatively well-contained change for two weeks!)

Thanks for responding so quick @DHowett-MSFT .

[say25]

Saw this in the release notes, but I can't seem to configure it in the profiles.json

[DHowett-MSFT]

@say25 okay we can only help you if you share with us what you've tried

[azchohfi]

You need to update to the latest version (0.10.761.0), then it works. Still, the schema is not giving me the splitMode property, on VSCode, but it works anyway. This is what I'm using:

{ "command": { "action": "splitPane", "split": "horizontal", "splitMode": "duplicate"}, "keys": "alt+shift+-" },
{ "command": { "action": "splitPane", "split": "vertical", "splitMode": "duplicate"}, "keys": "alt+shift+plus" },

[say25]

Yea its more that it doesn't show in the schema but im trying:

    "keybindings": [
        {
            "command": {
                "action": "splitPane",
                "split": "horizontal",
                "splitMode": "manual"
            },
            "keys": [
                "ctrl+_"
            ]
        }, 
        .....

[DHowett-MSFT]

So, you almost certainly want the duplicate splitMode, not the manual one. The schema hasn't been updated yet (sorry about that!)

[say25]

Well I actually kinda have an "odd use case" basically I'll be at one directory and/or have some amount of env. variables set in the shell (AWS/Azure creds) and then I need to switch from bash to powershell or vice versa. Maybe this feature doesnt entirely address that but it looked like it might