Add actions missing in schema, descriptions for toggleRetroEffect
#6806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
In the wake of #6635, a couple things got missed in merges:
toggleRetroEffect
didn't get into the schema, nor didrenameTab
orcommandPalette
.toggleRetroEffect
also didn't get a nameFurthermore, I thought it might be a good idea to start sticking
commands into
bindings
even withoutkeys
. So I tried doing that foropentabColorPicker
andtoggleRetroEffect
, and found immediately thatthe labels for the key chord still appear even when the text is empty.
So I added some XAML magic to hide those when the text is empty.
References
toggleRetroEffect
to schema #6762PR Checklist
toggleRetroEffect
to schema #6762Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Removed all my manual actions, ran the Terminal:
![image](https://user-images.githubusercontent.com/18356694/86652356-f5a79400-bfa9-11ea-9131-5b7d3e835e19.png)