Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to auto focus an error pane #8145

Closed
wants to merge 25 commits into from

Conversation

PankajBhojwani
Copy link
Contributor

Summary of the Pull Request

When a pane sends an OSC 9;4 sequence to indicate an error state, add a setting to focus that pane and flash the taskbar (note: we do not focus the window if the window is minimized).

References

#6700

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

Validation Steps Performed

TODO

@DHowett
Copy link
Member

DHowett commented Nov 3, 2020

Immediate concern: This is the first feature we're considering that will allow a misbehaving application to demand focus repeatedly.

@PankajBhojwani PankajBhojwani changed the title [DRAFT] Add a setting to auto focus an error pane Add a setting to auto focus an error pane Nov 6, 2020
@PankajBhojwani PankajBhojwani marked this pull request as ready for review November 6, 2020 16:53
Base automatically changed from dev/pabhoj/taskbar_progress to main November 18, 2020 22:24
@PankajBhojwani
Copy link
Contributor Author

Closed this because we have no good solution to DHowett's concern above

@DHowett DHowett deleted the dev/pabhoj/focus_error_pane branch October 26, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants