Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to disable pane entrance animation if user requests #8237

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Make sure to disable pane entrance animation if user requests #8237

merged 1 commit into from
Nov 13, 2020

Conversation

Don-Vito
Copy link
Contributor

No description provided.

@Don-Vito
Copy link
Contributor Author

@zadjii-msft - please review

@skyline75489
Copy link
Collaborator

skyline75489 commented Nov 12, 2020 •
edited
Loading

Is there a issue for this? I vaguely remember there is one...

@Don-Vito
Copy link
Contributor Author

Don-Vito commented Nov 12, 2020 •
edited
Loading

@skyline75489 - no issue for this. I encountered that while fixing #8230
And yesterday @zadjii-msft told me that for small fixes that I want to apply immediately no issue is required

@skyline75489
Copy link
Collaborator

skyline75489 commented Nov 12, 2020 via email •
edited by ghost
Loading

zadjii-msft
zadjii-msft approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's the darndest thing, the animation definitely doesn't play for me if I enable the setting. That's really bizarre. I'd love for someone else to confirm that the setting isn't working as it currently is, just for my own sanity.

In the meantime, this will definitely work, so :shipit:

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Nov 12, 2020
@Don-Vito
Copy link
Contributor Author

Don-Vito commented Nov 12, 2020 •
edited
Loading

Well that's the darndest thing, the animation definitely doesn't play for me if I enable the setting. That's really bizarre. I'd love for someone else to confirm that the setting isn't working as it currently is, just for my own sanity.

In the meantime, this will definitely work, so :shipit:

@zadjii-msft - sanity is important in our days 😄 . Do you say don't enter it even with a debugger (my debugger definitely gets there)

DHowett
DHowett approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye!

@DHowett DHowett changed the title Allow disabling entrance animation from settings Make sure to disable pane entrance animation if user requests Nov 13, 2020
@DHowett DHowett merged commit e801081 into microsoft:main Nov 13, 2020
DHowett pushed a commit that referenced this pull request Nov 20, 2020
@Don-Vito @DHowett
Make sure to disable pane entrance animation if user requests (#8237)
204c9d2 
We were only checking app animations during pane _exit_.

(cherry picked from commit e801081)
@ghost
Copy link

ghost commented Nov 20, 2020

🎉Windows Terminal Preview v1.5.3242.0 has been released which incorporates this pull request.:tada:

Handy links:

@Don-Vito Don-Vito deleted the allow-disabling-entrance-animation branch December 3, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Don-Vito @skyline75489 @DHowett @zadjii-msft