Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249: Remove trailing commas in profiles.schema.json #8257

Merged
merged 1 commit into from
Nov 13, 2020
Merged

8249: Remove trailing commas in profiles.schema.json #8257

merged 1 commit into from
Nov 13, 2020

Conversation

xiiok
Copy link
Contributor

@xiiok xiiok commented Nov 13, 2020

Summary of the Pull Request

Fixes https parsing of the latest version of profiles.schema.json, particularly by VS Code Intellisense.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

The VS Code parsing warning below is a known and unrelated existing issue due to VS Code only supporting JSON Schema Draft 7. It does not prevent Intellisense from functioning.

Draft 2019-09 schemas are not yet fully supported.

Validation Steps Performed

Manually tested and successfully validated by fixing a local copy of profiles.schema.json and defining it as $schema in settings.json

Sorry, something went wrong.

@ghost ghost added Area-Schema Things that have to do with the json schema. Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. labels Nov 13, 2020
@xiiok xiiok marked this pull request as ready for review November 13, 2020 06:32
Copy link
Contributor

@Don-Vito Don-Vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO looks perfect 👍

@Don-Vito
Copy link
Contributor

@zadjii-msft - please review.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this ☺️

@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Nov 13, 2020
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DHowett DHowett merged commit d28a4da into microsoft:main Nov 13, 2020
@xiiok xiiok deleted the 8249-fix-profiles-schema-json branch November 14, 2020 01:00
DHowett pushed a commit that referenced this pull request Nov 20, 2020
Fixes https parsing of the latest version of `profiles.schema.json`, particularly by VS Code Intellisense.

* [x] Closes #8249

The VS Code parsing warning below is a known and unrelated existing issue due to VS Code only supporting JSON Schema Draft 7. It does not prevent Intellisense from functioning.

> Draft 2019-09 schemas are not yet fully supported.

## Validation Steps Performed

Manually tested and successfully validated by fixing a local copy of `profiles.schema.json` and defining it as `$schema` in `settings.json`

(cherry picked from commit d28a4da)
@ghost
Copy link

ghost commented Nov 20, 2020

🎉Windows Terminal Preview v1.5.3242.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Schema Things that have to do with the json schema. Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing commas in profiles.schema.json breaks VS Code Intellisense
5 participants