-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8249: Remove trailing commas in profiles.schema.json #8257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO looks perfect 👍
@zadjii-msft - please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes https parsing of the latest version of `profiles.schema.json`, particularly by VS Code Intellisense. * [x] Closes #8249 The VS Code parsing warning below is a known and unrelated existing issue due to VS Code only supporting JSON Schema Draft 7. It does not prevent Intellisense from functioning. > Draft 2019-09 schemas are not yet fully supported. ## Validation Steps Performed Manually tested and successfully validated by fixing a local copy of `profiles.schema.json` and defining it as `$schema` in `settings.json` (cherry picked from commit d28a4da)
🎉 Handy links: |
Summary of the Pull Request
Fixes https parsing of the latest version of
profiles.schema.json
, particularly by VS Code Intellisense.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
The VS Code parsing warning below is a known and unrelated existing issue due to VS Code only supporting JSON Schema Draft 7. It does not prevent Intellisense from functioning.
Validation Steps Performed
Manually tested and successfully validated by fixing a local copy of
profiles.schema.json
and defining it as$schema
insettings.json