Fix next tab activation in focus mode upon tab closing #8549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-UserInterface
|
@zadjii-msft - Happy Hanukkah! |
Don-Vito
changed the title
|
@zadjii-msft - not sure what static analyzer wants, I added a single word to the code 😄 |
34 tasks
ghost
requested review from
miniksa,
carlos-zamora,
DHowett,
leonMSFT and
PankajBhojwani
carlos-zamora
approved these changes
Dec 11, 2020
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
reviewed
Dec 11, 2020
| @@ -1136,13 +1136,16 @@ namespace winrt::TerminalApp::implementation | |||
| { | |||
| _lastTabClosedHandlers(*this, nullptr); | |||
| } | |||
| else if (_isFullscreen || _rearranging) | |||
| else if (_isFullscreen || _rearranging || _isInFocusMode) | |||
There was a problem hiding this comment.
idle thought: should this just be checking the visibility of TabView versus Collapsed? lol
|
🎉 Handy links: |
ghost
mentioned this pull request
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
## PR Checklist * [x] Closes microsoft#7916 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments Upon tab close the tabview is responsible to issue tab selection for the next active tab. However this doesn't happen when tabview is hidden. There was a special treatment for this scenario for full screen mode. Added the same treatment to focus mode (as the tabview is not visible in this case as well). ## Validation Steps Performed Manual tests
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Upon tab close the tabview is responsible to issue tab selection for the next active tab.
However this doesn't happen when tabview is hidden.
There was a special treatment for this scenario for full screen mode.
Added the same treatment to focus mode (as the tabview is not visible in this case as well).
Validation Steps Performed
Manual tests