Add support for the DECID report #8864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Issue-Feature
j4james
commented
Jan 23, 2021
| @@ -226,6 +226,10 @@ bool OutputStateMachineEngine::ActionEscDispatch(const VTID id) | |||
| success = _dispatch->HorizontalTabSet(); | |||
| TermTelemetry::Instance().Log(TermTelemetry::Codes::HTS); | |||
| break; | |||
| case EscActionCodes::DECID_IdentifyDevice: | |||
| success = _dispatch->DeviceAttributes(); | |||
| TermTelemetry::Instance().Log(TermTelemetry::Codes::DA); | |||
There was a problem hiding this comment.
Note that I've reused the DA telemetry code here, since this is essentially an alias for the Device Attributes report, but I'd be happy to create a separate telemetry code for it if that's preferable.
There was a problem hiding this comment.
meh, it's not like that's used for anything anyways 😛
zadjii-msft
approved these changes
Jan 25, 2021
| @@ -226,6 +226,10 @@ bool OutputStateMachineEngine::ActionEscDispatch(const VTID id) | |||
| success = _dispatch->HorizontalTabSet(); | |||
| TermTelemetry::Instance().Log(TermTelemetry::Codes::HTS); | |||
| break; | |||
| case EscActionCodes::DECID_IdentifyDevice: | |||
| success = _dispatch->DeviceAttributes(); | |||
| TermTelemetry::Instance().Log(TermTelemetry::Codes::DA); | |||
There was a problem hiding this comment.
meh, it's not like that's used for anything anyways 😛
ghost
requested review from
miniksa,
carlos-zamora,
DHowett,
leonMSFT and
PankajBhojwani
carlos-zamora
approved these changes
Jan 25, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
ghost
mentioned this pull request
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
This PR adds support for the `DECID` (Identify Device) escape sequence, which allows for querying the terminal type in a way that is backwards compatible with VT52 terminals. This simply checks for the `ESC Z` sequence in the `ActionEscDispatch` method of output state machine, and forwards the query to the existing `DeviceAttributes` dispatch method, since the expected response is identical to a `DA` report. ## Validation Steps Performed I've added an output engine test that verifies that the `ESC Z` sequence is correctly interpreted as a `DA` query when in ANSI mode, and as a VT52 identification query when in VT52 mode. Closes microsoft#8857
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
DECID(Identify Device) escape sequence,which allows for querying the terminal type in a way that is backwards
compatible with VT52 terminals.
This simply checks for the
ESC Zsequence in theActionEscDispatchmethod of output state machine, and forwards the query to the existing
DeviceAttributesdispatch method, since the expected response isidentical to a
DAreport.Validation Steps Performed
I've added an output engine test that verifies that the
ESC Zsequenceis correctly interpreted as a
DAquery when in ANSI mode, and as aVT52 identification query when in VT52 mode.
Closes #8857