Add information about which assembly failed to discover test into #299
Conversation
There was a problem hiding this comment.
Thanks for the PR @kant2002 . Looks good overall . Can you add/modify tests as well please?
Also please run build.cmd -uxlf so the string addition is localizable. You would have to commit the xlf file changes post running the script.
| var winrtFailureMessage = string.Format( | ||
| CultureInfo.CurrentCulture, | ||
| Resource.TestAssembly_WinRTAssemblyDiscoveryFailure, | ||
| fullFilePath, |
There was a problem hiding this comment.
This should be assemblyFullName.
| @@ -299,4 +299,10 @@ | |||
| <data name="DiscoveryWarning" xml:space="preserve"> | |||
| <value>[MSTest][Discovery][{0}] {1}</value> | |||
| </data> | |||
| <data name="TestAssembly_AssemblyDiscoveryFailure" xml:space="preserve"> | |||
| <value>Failed to discover tests from assembly located at {0}. Reason:{1}</value> | |||
There was a problem hiding this comment.
Suggestion: Can we only have one string with a
Failed to discover tests from assembly {0}. Reason:{1}
| CultureInfo.CurrentCulture, | ||
| Resource.TestAssembly_AssemblyDiscoveryFailure, | ||
| fullFilePath, | ||
| ex.Message); | ||
| warnings.Add(ex.Message); |
There was a problem hiding this comment.
This should be warnings.Add(message)
|
Ooh, I forgot to run tests, since was sidetracked with build issues. Will take a look. |
|
@AbhitejJohn I actually blocked with #300 without ability to do clean build, so when I build solution the failed test does not run, since assembly where it is probably missing. Could you take a look what could I install to make build works. |
|
@kant2002 : Following up on this. Can you please do the needful to complete this PR? |
|
@jayaranigarg thanks for your patience, I have some issues with my VS setup after 15.4 update probably which prevent me from do clean build. I try to reinstall VS now and check patch again. I will report back when I finish with VS install |
Having indicate location of the assembly from which discovery happens allow developer reason about possible failures, and manually troubleshoot his configuration issues which cause asembly to fail
* Single messages for assembly loading failure * Display assembly name for WinRT assembly loading
kant2002
force-pushed
the
diagnostic-improvements
branch
from
2d8e507 to
b36ab35
Compare
|
@jayaranigarg or @AbhitejJohn please take a look |
|
@kant2002 : Thank you for completing this. Looks good to me. Will push this in. |
Having indicate location of the assembly from which discovery happens allow developer reason about possible failures, and manually troubleshoot his configuration issues which cause asembly to fail
This allow simplify resolution of the issues like #295 and similar where it is not clear what exactly happens. For example when you run tests from multiple assemblies, like in VSTS CI build