Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nullable-annotated Assert.IsNotNull #744

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Add nullable-annotated Assert.IsNotNull #744

merged 1 commit into from
Nov 12, 2020

Conversation

Haplois
Copy link
Contributor

@Haplois Haplois commented Nov 12, 2020 •
edited
Loading

nohwnd
nohwnd approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@nohwnd nohwnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haplois Haplois merged commit e9bc669 into microsoft:master Nov 12, 2020
@Haplois Haplois deleted the null-aware branch November 12, 2020 14:49
@CodeBlanch
Copy link

Is there any timeline for this being available in the NuGet package? I'm getting a lot of CS8602 warnings now in my tests (using VS16.9.0 Preview 1) which cause build breakage w/ TreatWarningsAsErrors enabled.

@Haplois
Copy link
Contributor Author

Haplois commented Nov 26, 2020

We will release a preview package tomorrow.

@CodeBlanch
Copy link

I updated to the latest preview and the warnings are gone thanks @Haplois!

@Haplois Haplois mentioned this pull request Jul 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nohwnd nohwnd nohwnd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nullable Reference Type-aware support?
3 participants
@Haplois @CodeBlanch @nohwnd