Restore the use of --override and --overrides-file when --manifest-js is specified #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bworline
changed the title
anatolybolshakov
approved these changes
Oct 1, 2021
max-zaytsev
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are valid scenarios where you may want to use both --manifest-js and --override or --overrides-file. For example, in ADO pipeline publishing to update the extension version with the build version from the pipeline.
In fact, the internal implementation of --publisher and --extension-id also depend on this override functionality. This PR will allow them to be used with --manifest-js.
This PR is in response to a comment from PR #342 by @dwilsonactual.