Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #398

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Update dependencies #398

merged 3 commits into from
Dec 20, 2021

Conversation

max-zaytsev
Copy link

@max-zaytsev max-zaytsev commented Dec 10, 2021 •
edited
Loading

Update dependencies to resolve vulnerability issues.
Bumped up "azure-devops-node-api" from "^8.1.1" to "^10.2.2"

List of commands tested locally:

  • login
  • workitem create
  • workitem query
  • workitem update
  • workitem show
  • build list
  • build queue
  • build show
  • build tasks create
  • build tasks upload
  • build tasks list
  • build tasks delete
  • extension create
  • extension create
  • extension init
  • extension isvalid
  • extension publish
  • extension show
  • extension share
  • extension unpublish
  • extension unshare
  • extension resources

Related issue: #380

  • There are no risky dependency updates
  • Changes have been tested
  • Enough test coverage for changes and current test coverage for the task doesn't look poor
    There are no tests yet. Tested manually
  • We understand how tasks are working, how changes affect task behavior
  • There are no breaking changes
  • There are no other concerns
  • I have not discovered any new uncovered test/use cases
    There are no tests yet. Tested manually

@max-zaytsev max-zaytsev requested review from anatolybolshakov and a team December 10, 2021 15:06
@AndreyIvanov42 AndreyIvanov42 mentioned this pull request Dec 13, 2021
Closed
anatolybolshakov
anatolybolshakov approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Please take a look at comments also

@AndreyIvanov42
Copy link

Manually tested. Command functionality is not suffered

@anatolybolshakov
Copy link
Contributor

@alexander-smolyakov could you please take a look?

@max-zaytsev max-zaytsev merged commit d49fb32 into master Dec 20, 2021
@max-zaytsev max-zaytsev deleted the users/max-zaytsev/update-dependencies branch December 20, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyIvanov42 AndreyIvanov42 AndreyIvanov42 approved these changes

@alexander-smolyakov alexander-smolyakov alexander-smolyakov approved these changes

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@max-zaytsev @AndreyIvanov42 @anatolybolshakov @alexander-smolyakov