-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump lightning[pytorch-extra] from 2.2.5 to 2.3.0 in /requirements #2119
Bump lightning[pytorch-extra] from 2.2.5 to 2.3.0 in /requirements #2119
Conversation
Broken due to Lightning-AI/pytorch-lightning#19977 |
ce43a80
to
7947b62
Compare
7947b62
to
70c652a
Compare
2.3.0 and 2.3.1 are both broken due to the same bug. I don't know why dependabot opened two separate PRs for 2.3.0 and 2.3.1, but we can't upgrade to either just yet. |
Bumps [lightning[pytorch-extra]](https://github.com/Lightning-AI/lightning) from 2.2.5 to 2.3.0. - [Release notes](https://github.com/Lightning-AI/lightning/releases) - [Commits](Lightning-AI/pytorch-lightning@2.2.5...2.3.0) --- updated-dependencies: - dependency-name: lightning[pytorch-extra] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
70c652a
to
4cccbf9
Compare
Should the |
@CarlosGomes98 let me dig a bit deeper to understand what changed and whether or not it's only the format of the config files or also command-line usage. Also want to determine if this was intentional or accidental. Once I know the answers to those questions, we can either fix the bug in lightning or change TorchGeo to support newer lightning. I don't want to get stuck on older versions of lightning for a silly reason like this. Our release cycle is slow enough that by the time a version pin made it into a released version, the bug will likely be fixed already anyway (for better or for worse, I would like to speed up our release cycle someday). |
@CarlosGomes98 I think you're right, let's add an upper bound. Hopefully this will get fixed before our next release, but just in case let's prevent broken installs. |
Closing until Lightning-AI/pytorch-lightning#19977 is resolved. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps lightning[pytorch-extra] from 2.2.5 to 2.3.0.
Release notes
Sourced from lightning[pytorch-extra]'s releases.
... (truncated)
Commits
a42484c
Fix failing app tests (#19971)f6fd046
Release 2.3.0 (#19954)a97814a
Update README.mdfa5da26
Update README.md (#19968)06ea3a0
Fix resetting epoch loop restarting flag in LearningRateFinder (#19819)5fa32d9
Ignore parameters causing ValueError when dumping to YAML (#19804)4f96c83
Sanitize argument-free object params before logging (#19771)a611de0
Removing numpy requirement from all files in examples/pytorch/domain_template...812ffde
Fixsave_last
type annotation for ModelCheckpoint (#19808)7668a6b
Flexible and easy to use HSDP setting (#19504)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)