Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Enabled the no-any rule. #570

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Enabled the no-any rule. #570

merged 1 commit into from
Oct 23, 2018

Conversation

reduckted
Copy link
Contributor

Fixes #566.

There were no major problems making these changes, but there are a few things that I'll point out in comments against the changes.

@reduckted reduckted mentioned this pull request Oct 20, 2018
Closed
17 tasks
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 23, 2018
View reviewed changes
Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic, thanks so much @reduckted!

+1 to your inline comments, those were quite helpful 😊

@JoshuaKGoldberg JoshuaKGoldberg merged commit 31529b2 into microsoft:master Oct 23, 2018
@JoshuaKGoldberg
Copy link

Coming back to this @reduckted, I think I was wrong to ask to use options: null. I haven't found any problems with using options: undefined in TSLint (why would there be? it's just for docs generation) and there's no motivation to use null. Sorry for the extra churn 😊 I'll switch it back to the superior undefined.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0-beta0 milestone Nov 6, 2018
@reduckted reduckted deleted the 566-enable-no-any branch December 30, 2018 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@reduckted @JoshuaKGoldberg