Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Remove absolute path from rules error messages. #641

Merged

Conversation

IllusionMH
Copy link
Contributor

@IllusionMH IllusionMH commented Nov 5, 2018

PR checklist

Overview of change:

  • export-name now has only base file name in error message.
  • missing-jsdoc removed filename from error message
  • react-no-dangerous-html filename from error message

I haven't changed how string concatenations is made for multiline errors because anyway they will be migrated soon.

Is there anything you'd like reviewers to focus on?

Added inline comment.

This PR with template looks better and important :)

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8663087 into microsoft:master Nov 5, 2018
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0-beta0 milestone Nov 6, 2018
@IllusionMH IllusionMH deleted the remove-absolute-path-634 branch December 1, 2018 01:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Remove absolute paths from error messages (ideally before 6.0)
2 participants