Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handling for when we have network failures in the retry mechanism #223

Merged
merged 4 commits into from
Jun 30, 2020

Conversation

mastrzyz
Copy link
Contributor

This will add handling when we have a network failure.
Occurs when the ADO Connection itself goes down and not return any status code.

The following network errors will be retried 'ECONNRESET', 'ENOTFOUND', 'ESOCKETTIMEDOUT', 'ETIMEDOUT', 'ECONNREFUSED'

Copy link

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests seem unrelated - guessing they're from a dependency since they're only showing up in integration tests, not the mocked units. I'm good with merging this once my comment is addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants