Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Python emitter keeps adding this line at the top, even though one already exists: # pylint: disable=too-many-lines #5526

Closed
4 tasks done
dargilco opened this issue Jan 8, 2025 · 1 comment · Fixed by #5539
Closed
4 tasks done

[Bug]: Python emitter keeps adding this line at the top, even though one already exists: # pylint: disable=too-many-lines #5526

dargilco opened this issue Jan 8, 2025 · 1 comment · Fixed by #5539
Labels
bug Something isn't working emitter:client:python Issue for the Python client emitter: @typespec/http-client-python

Comments

@dargilco
Copy link
Member

dargilco commented Jan 8, 2025

Describe the bug

Whenever I emit Python SDK from TypeSpec, the line # pylint: disable=too-many-lines keeps getting added to the top one or more of my _patch.py files, even though this line already exists there at the top. I have to manually delete the repeated line after each re-emit.

See attached screen shot of a file diff after SDK was re-emitted. Image

Reproduction

Have a _patch.py file with this line at the top: # pylint: disable=too-many-lines. Re-emit the Python SDK, and see that the same line was added again below the original one.

Checklist
@dargilco dargilco added the bug Something isn't working label Jan 8, 2025
@dargilco
Copy link
Member Author

dargilco commented Jan 8, 2025

Tagging @iscai-msft for triage. Thanks!

@markcowl markcowl added the emitter:client:python Issue for the Python client emitter: @typespec/http-client-python label Jan 8, 2025
@iscai-msft iscai-msft mentioned this issue Jan 8, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2025
@iscai-msft
[python] don't add too-many-lines disable if already exists (#5539)
80039bd 
fixes #5526

---------

Co-authored-by: iscai-msft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working emitter:client:python Issue for the Python client emitter: @typespec/http-client-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[python] don't add too-many-lines disable if already exists iscai-msft/typespec
2 participants
@markcowl @dargilco