Fix handling of decorators on parameters in openapi3 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekistler
requested review from
allenjzhang,
bterlson,
daviwil,
markcowl and
nguerrera
as code owners
mikekistler
force-pushed
the
mdk/fix-openapi-param-decorators
branch
from
06f9beb to
6d4ea0b
Compare
nguerrera
approved these changes
Oct 23, 2021
weidongxu-microsoft
pushed a commit
to weidongxu-microsoft/typespec
that referenced
this pull request
Oct 22, 2024
* Very early testing creating model declaration java component and getting data from tsp file. microsoft#6 * Setup exporting java directory * Add file based on type-expression.tsx in the typescript directory. This will handle getting a java representation of a typespec type. microsoft#6 * Add some logging to see what is in the Model type. * Add a ModelProperty for testing. * Update to use TypeExpression. microsoft#6 * Create component to handle a model constructor. microsoft#6 * Create component to handle members of constructor. microsoft#6 * Fix indentation partially. microsoft#6 * Improved indentation. microsoft#6 * Improved indentation. microsoft#6 * Implement providing getter and setter methods. microsoft#6 * Implement providing getter and setter methods. microsoft#6 * Remove unused imports. microsoft#6 * Add source file component for models. microsoft#6 * Add source file component for models. microsoft#6 * Fix indentation. microsoft#6 * Use model source file to get a source file from the Model collected from the tsp file. microsoft#6 * Add constructor with no parameters. microsoft#6 * Fix to return a variable with private access modifier. microsoft#6 * Improve formating of output. microsoft#6 * Use more complex sample tsp for testing. microsoft#6 * Improve formating. microsoft#6 * Implement basic model type expression for array. microsoft#6 * Add export * Remove logging microsoft#6 * Remove logging and add second model source file microsoft#6 * Move logic for getting data from model to utility functions microsoft#6 * Utility functions for getting names and types from model microsoft#6 * Add case for ModelProperty type microsoft#6 * Cleaning up old comments microsoft#6 --------- Co-authored-by: Jamin <[email protected]>
steverice
added a commit
to steverice/typespec
that referenced
this pull request
Feb 3, 2025
This should fix the issue ```microsoft#10 0.515 Error: Cannot find matching keyid: {"signatures":[{"sig":"MEQCIHGqHbvc2zImUPEPFpT4grh6rMYslel+lAjFArx8+RUdAiBfnJA+bgmUvO5Lctfkq+46KKDQdx/8RhLPge3pA+EdHA==","keyid":"SHA256:DhQ8wR5APBvFHLF/+Tc+AYvPOdTpcIDqOhxsBHRwC7U"}],"keys":[{"expires":null,"keyid":"SHA256:jl3bwswu80PjjokCgh0o2w5c2U4LhQAE57gj9cz1kzA","keytype":"ecdsa-sha2-nistp256","scheme":"ecdsa-sha2-nistp256","key":"MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAE1Olb3zMAFFxXKHiIkQO5cJ3Yhl5i6UPp+IhuteBJbuHcA5UogKo0EWtlWwW6KSaKoTNEYL7JlCQiVnkhBktUgg=="}]} ``` when running docker builds. See pnpm/pnpm#9014 (comment) for more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the way decorators are applied to parameters in the openapi3 emitter. In OpenAPI 3, all parameters have a "schema", and the decorators must be applied to the schema rather than directly to the parameter.