Symbol refactor #4849
Merged
Symbol refactor #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
changed the title
microsoft-github-policy-service
bot
added
the
compiler:core
|
All changed packages have been documented.
|
|
You can try these changes here
|
|
another thing is could this refactor resolve the spread issue? playground |
|
Could you help guide on cases here? It seems not working. another question is any document on how to refer typemetada in typespec? |
Spread of template parameter we cannot as it's something done dynamically, only works if we know the template param constraint |
timotheeguerin
commented
Nov 4, 2024
…rom every parent node
bterlson
approved these changes
Nov 4, 2024
markcowl
approved these changes
Nov 4, 2024
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
### Augment decorator issues Fix microsoft#4749 Augment/ref alias properties Fix microsoft#2867 Augment/ref `model is` properties Fix microsoft#4818 Augment/ref nested model properties ### Circular reference issues Fix microsoft#4908 freeze when using circular model extends with aliases ### Others FIx microsoft#4915 (Duplicate usings not scoped per namespace) Doesn't resolve the alias circular issue microsoft#2824 but I think setup the solution for fixing it later in the name resolver where we could detect that cycle instead of the checker --------- Co-authored-by: Brian Terlson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment decorator issues
Fix #4749 Augment/ref alias properties
Fix #2867 Augment/ref
model ispropertiesFix #4818 Augment/ref nested model properties
Circular reference issues
Fix #4908 freeze when using circular model extends with aliases
Others
FIx #4915 (Duplicate usings not scoped per namespace)
Doesn't resolve the alias circular issue #2824 but I think setup the solution for fixing it later in the name resolver where we could detect that cycle instead of the checker