Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "-ForceEnglishOutput" flag to the NuGet help command in tools.cpp #1451

Merged

Conversation

kazssym
Copy link
Contributor

@kazssym kazssym commented Jul 6, 2024

This pull request rewrites #1418 without adding any new function for regex matching. Instead, it uses the nuget help -ForceEnglishOutput command instead of just the plain nuget command used to detect its version.

Fixes microsoft/vcpkg#38940.

@kazssym kazssym marked this pull request as ready for review July 6, 2024 11:50
@BillyONeal BillyONeal merged commit 3ab647c into microsoft:main Jul 8, 2024
5 checks passed
@BillyONeal
Copy link
Member

Awesome, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcpkg.exe cannot determine the version of the downloaded nuget.exe.
2 participants