Skip to content

Commit

Permalink
[vcxproj] Explicitly specify intermediate and output directories
Browse files Browse the repository at this point in the history
Avoids case-sensitivity issues, flattens the layout, no Win32 but x86 instead
Issue #4586
  • Loading branch information
alexkaratarakis committed Nov 1, 2018
1 parent 0ad1997 commit 5a1a75d
Show file tree
Hide file tree
Showing 7 changed files with 71 additions and 6 deletions.
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,10 @@ __pycache__/
/packages/
/scripts/buildsystems/tmp/
/toolsrc/build.rel/
/toolsrc/msbuild.x86.debug/
/toolsrc/msbuild.x86.release/
/toolsrc/msbuild.x64.debug/
/toolsrc/msbuild.x64.release/
#ignore custom triplets
/triplets/*
#add vcpkg-designed triplets back in
Expand Down
4 changes: 2 additions & 2 deletions scripts/bootstrap.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ if ($disableMetrics)
}

$platform = "x86"
$vcpkgReleaseDir = "$vcpkgSourcesPath\release"
$vcpkgReleaseDir = "$vcpkgSourcesPath\msbuild.x86.release"

if ($win64)
{
Expand All @@ -339,7 +339,7 @@ if ($win64)
}

$platform = "x64"
$vcpkgReleaseDir = "$vcpkgSourcesPath\x64\release"
$vcpkgReleaseDir = "$vcpkgSourcesPath\msbuild.x64.release"
}

$arguments = (
Expand Down
2 changes: 1 addition & 1 deletion toolsrc/dirs.proj
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<SolutionDir>$(MSBuildThisFileDirectory)</SolutionDir>
</PropertyGroup>
<ItemGroup>
<ProjectFile Include="vcpkg\vcpkg.vcxproj"/>
<ProjectFile Include="vcpkglib\vcpkglib.vcxproj"/>
<ProjectFile Include="vcpkg\vcpkg.vcxproj"/>
<ProjectFile Include="vcpkgmetricsuploader\vcpkgmetricsuploader.vcxproj"/>
</ItemGroup>

Expand Down
17 changes: 16 additions & 1 deletion toolsrc/vcpkg/vcpkg.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,22 @@
<ImportGroup Label="Shared">
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<PropertyGroup />
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<IntDir>$(SolutionDir)msbuild.x86.debug\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x86.debug\</OutDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<OutDir>$(SolutionDir)msbuild.x86.release\</OutDir>
<IntDir>$(SolutionDir)msbuild.x86.release\$(ProjectName)\</IntDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<IntDir>$(SolutionDir)msbuild.x64.debug\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x64.debug\</OutDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<IntDir>$(SolutionDir)msbuild.x64.release\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x64.release\</OutDir>
</PropertyGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<ClCompile>
<WarningLevel>Level4</WarningLevel>
Expand Down
17 changes: 16 additions & 1 deletion toolsrc/vcpkglib/vcpkglib.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,22 @@
<ImportGroup Label="Shared">
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<PropertyGroup />
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<IntDir>$(SolutionDir)msbuild.x86.debug\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x86.debug\</OutDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<OutDir>$(SolutionDir)msbuild.x86.release\</OutDir>
<IntDir>$(SolutionDir)msbuild.x86.release\$(ProjectName)\</IntDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<IntDir>$(SolutionDir)msbuild.x64.debug\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x64.debug\</OutDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<IntDir>$(SolutionDir)msbuild.x64.release\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x64.release\</OutDir>
</PropertyGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<ClCompile>
<WarningLevel>Level3</WarningLevel>
Expand Down
17 changes: 16 additions & 1 deletion toolsrc/vcpkgmetricsuploader/vcpkgmetricsuploader.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,22 @@
<ImportGroup Label="Shared">
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<PropertyGroup />
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<IntDir>$(SolutionDir)msbuild.x86.debug\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x86.debug\</OutDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<OutDir>$(SolutionDir)msbuild.x86.release\</OutDir>
<IntDir>$(SolutionDir)msbuild.x86.release\$(ProjectName)\</IntDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<IntDir>$(SolutionDir)msbuild.x64.debug\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x64.debug\</OutDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<IntDir>$(SolutionDir)msbuild.x64.release\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x64.release\</OutDir>
</PropertyGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<ClCompile>
<WarningLevel>Level3</WarningLevel>
Expand Down
16 changes: 16 additions & 0 deletions toolsrc/vcpkgtest/vcpkgtest.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,22 @@
<ImportGroup Label="Shared">
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<IntDir>$(SolutionDir)msbuild.x86.debug\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x86.debug\</OutDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<OutDir>$(SolutionDir)msbuild.x86.release\</OutDir>
<IntDir>$(SolutionDir)msbuild.x86.release\$(ProjectName)\</IntDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<IntDir>$(SolutionDir)msbuild.x64.debug\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x64.debug\</OutDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<IntDir>$(SolutionDir)msbuild.x64.release\$(ProjectName)\</IntDir>
<OutDir>$(SolutionDir)msbuild.x64.release\</OutDir>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<LinkIncremental>true</LinkIncremental>
</PropertyGroup>
Expand Down

0 comments on commit 5a1a75d

Please sign in to comment.