-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fribidi build failure on Linux #9035
Comments
Hi @grdowns, there are this information in config-x64-linux-rel-out.log:
I don't know how to fix this issue. Could you help to fix it? Thanks. |
- Fixes microsoft#7412 by using gtk 3.24.10. - Possibly fixes microsoft#6554, microsoft#7827, microsoft#8103 as now all the missing assets are correctly copied into installed/<triplet>/share/ and should be deployed with the final application. This simplify the gtk port and correctly generate the missing files. The source of the problem is with the underlying build system, as these files were installed by the demo `icon-browser`, but the gtk-update-icon-cache were executed by the main gtk project, failing if the demo wasn't built or installed. - This also fixes microsoft#7641 as now the meson build will correctly generate the missing .pc files. - This also fixes microsoft#9035, microsoft#7150 by fixing `vcpkg_configure_meson.cmake` which fails on Linux/OSX because it indiscriminately try to pass msvc cl arguments to the cmake c/xx flags. Although this works, it is not the ideal fix. The correct fix would be to do as suggested in issue microsoft#8271. Also see issue microsoft#8630.
Hi, I just encountered the same issue. I updated my meson cmake file and it works. Why isn't this fix merged into vcpkg? |
hey, what did you do? i'm new and have no idea what to do |
Bump
Contents of x64-linux-dynamic triplet: set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE dynamic)
set(VCPKG_CMAKE_SYSTEM_NAME Linux)
set(VCPKG_CXX_FLAGS "-Wl,-rpath,'$ORIGIN/../lib'")
set(VCPKG_C_FLAGS "-Wl,-rpath,'$ORIGIN/../lib'")
set(VCPKG_LINKER_FLAGS "-Wl,-rpath,'$ORIGIN/../lib'") There is only one line in
UPD2: Upon closer look, it seems that there is an issue with meson. It does not escape set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE dynamic)
set(VCPKG_CMAKE_SYSTEM_NAME Linux)
if(PORT MATCHES "fribidi")
set(pretty_ORIGIN_name "\$ORIGIN")
set(VCPKG_LINKER_FLAGS "-Wl,-rpath,${pretty_ORIGIN_name}:${pretty_ORIGIN_name}/../lib")
else()
set(VCPKG_LINKER_FLAGS "-Wl,-rpath,'$ORIGIN':'$ORIGIN/../lib'")
endif() Also note that setting
|
@Osyotr, could you create a new issue for your problem? it's a different issue with original one. |
Thanks for posting this issue. |
Host Environment
To Reproduce
Steps to reproduce the behavior:
./vcpkg install fribidi
Failure logs
Additional context
Windows x86 and x64 builds like a breeze.
The text was updated successfully, but these errors were encountered: