Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in vcpkg_from_gitlab #9228

Closed
RamadanAhmed opened this issue Dec 5, 2019 · 0 comments · Fixed by #9248
Closed

Bug in vcpkg_from_gitlab #9228

RamadanAhmed opened this issue Dec 5, 2019 · 0 comments · Fixed by #9248
Assignees
@dan-shaw
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Comments

@RamadanAhmed
Copy link
Contributor

RamadanAhmed commented Dec 5, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
vcpkg_from_gitlab doesn't take into account subgroups after organizations name
for example: organization/cpp/project
Proposed solution
I didn't dig into vcpkg_from_gitlab but I think it could be added easily
@RamadanAhmed RamadanAhmed added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Dec 5, 2019
@NancyLi1013 NancyLi1013 assigned grdowns and unassigned NancyLi1013 Dec 6, 2019
@JackBoosY JackBoosY assigned dan-shaw and unassigned grdowns Jun 9, 2020
@RamadanAhmed RamadanAhmed mentioned this issue Jun 9, 2020
Merged
strega-nil pushed a commit that referenced this issue Jul 30, 2020
@RamadanAhmed
fix issue #9228 : Add support to subgroups in gitlab (#9248)
b840d03 
* fix issue #9228 : Add support to subgroups in gitlab

* Update vcpkg_from_gitlab.cmake

* Update vcpkg_from_gitlab.cmake
hellozee pushed a commit to hellozee/vcpkg that referenced this issue Sep 11, 2020
@RamadanAhmed @hellozee
fix issue microsoft#9228 : Add support to subgroups in gitlab (micros…
b7e6ff1 
…oft#9248)

* fix issue microsoft#9228 : Add support to subgroups in gitlab

* Update vcpkg_from_gitlab.cmake

* Update vcpkg_from_gitlab.cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dan-shaw dan-shaw

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix issue #9228 : Add support to subgroups in gitlab
4 participants
@grdowns @RamadanAhmed @NancyLi1013 @dan-shaw