Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtk] Add find dependency pugixml in cmake config file #10379

Merged
merged 3 commits into from
Mar 28, 2020
Merged

[vtk] Add find dependency pugixml in cmake config file #10379

merged 3 commits into from
Mar 28, 2020

Conversation

JackBoosY
Copy link
Contributor

When using vtk, VTKTargets.cmake calls pugixml by name. However, VTKConfig.cmake did not add the code to find pugixml, so I added it.

Related: #9947.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Mar 11, 2020
@JackBoosY
Copy link
Contributor Author

@dbonhaus @manvscode @RamanKutseika @jasjuang
Could you test this PR?

Thanks.

manvscode
manvscode suggested changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@manvscode manvscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are not working for me. I don't have permission to pull down your branch so I had to manually apply your changes.

ports/vtk/fix-pugixml-link.patch Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor Author

Will rerun CI test after #10390 merged.

@PhoebeHui PhoebeHui marked this pull request as ready for review March 13, 2020 00:04
@JackBoosY JackBoosY requested a review from PhoebeHui March 16, 2020 02:16
@JackBoosY
Copy link
Contributor Author

/azp run

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Mar 27, 2020
@dan-shaw dan-shaw merged commit b5deb0c into microsoft:master Mar 28, 2020
@JackBoosY JackBoosY deleted the dev/jack/9947 branch March 30, 2020 03:36
@JackBoosY JackBoosY mentioned this pull request Mar 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manvscode manvscode manvscode requested changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @manvscode @PhoebeHui @dan-shaw