[gmp,nettle,hogweed] Add new ports #10613

Neumann-A · 2020-03-30T20:35:38Z

Describe the pull request
New ports: gmp, nettle (including hogweed)

requires (and includes for CI testing) #9861 (this PR starts at 9307095)

Felt like these should be separated from the X window PR

use --define-variable=prefix=INSTALL_PATH

Note: since CMake is run in script mode the description of VCPKG_FIXUP_PKGCONFIG_CALLED cannot be viewed

…add_gmp_nettle

CI seems to not pass env YASMPATH correctly to cl. Since YASM is on PATH -> remove $(VCInstallDir) as the default for YasmPath

Neumann-A · 2020-03-31T07:58:21Z

Hmm:

Starting package 2/2: gmp:x64-windows
Building package gmp[core]:x64-windows...
-- Using cached D:/vcpkg_common/downloads/ShiftMediaProject-gmp-e140dfc8668e96d7e56cbd46467945adcc6b3cc4.tar.gz
-- Extracting source D:/vcpkg_common/downloads/ShiftMediaProject-gmp-e140dfc8668e96d7e56cbd46467945adcc6b3cc4.tar.gz
-- Applying patch vs.build.patch
-- Using source at D:/qt/buildtrees/gmp/src/adcc6b3cc4-a9dac07c3d
-- Building SMP/libgmp.sln for Release
-- Building SMP/libgmp.sln for Debug
-- Installing: D:/qt/packages/gmp_x64-windows/share/gmp/copyright
-- Fixing pkgconfig
-- Fixing pkgconfig - release
-- Checking file: D:/qt/packages/gmp_x64-windows/lib/pkgconfig/gmp.pc
-- Checking file: D:/qt/packages/gmp_x64-windows/lib/pkgconfig/gmpxx.pc
-- Fixing pkgconfig - debug
-- Checking file: D:/qt/packages/gmp_x64-windows/debug/lib/pkgconfig/gmp.pc
-- Checking file: D:/qt/packages/gmp_x64-windows/debug/lib/pkgconfig/gmpxx.pc
-- Fixing pkgconfig --- finished
-- Performing post-build validation
-- Performing post-build validation done
Building package gmp[core]:x64-windows... done
Installing package gmp[core]:x64-windows...
Installing package gmp[core]:x64-windows... done

without failure logs from CI I won't know what went wrong.

MVoz · 2020-03-31T09:00:24Z

@Neumann-A version msvc ? maybe does not find yasm.exe

problem msvc 2019
#10523

Neumann-A · 2020-04-09T18:24:43Z

switched to draft until #9861 is merged

# Conflicts: # scripts/cmake/vcpkg_fixup_pkgconfig.cmake

Neumann-A · 2020-05-07T11:53:17Z

Requesting a clean rebuild. 3ba8f9f was green and I did not touch anything important since then. The UWP log also looks like an old failure.

JackBoosY · 2020-05-08T02:19:49Z

/azp run

azure-pipelines · 2020-05-08T02:19:58Z

Azure Pipelines successfully started running 1 pipeline(s).

strega-nil · 2020-05-08T20:55:06Z

Cool, thanks much @Neumann-A :D

JackBoosY · 2020-05-09T08:19:01Z

When building gmp:x86-windows:

    2>F:\vcpkg\installed\x86-windows\share\vs-yasm\yasm.targets(50,5): error MSB3721: The command ""F:/vcpkg/downloads/tools/yasm/1.3.0.6/"yasm.exe -Xvc -f win32 -o "F:\vcpkg\buildtrees\gmp\x86-windows-rel\adcc6b3cc4-2b6258d695\SMP\obj\ReleaseDLL\Win32\libgmp\addmul_1.obj" -rraw -pgas  "F:\vcpkg\buildtrees\gmp\x86-windows-rel\adcc6b3cc4-2b6258d695\SMP\mpn\x86\addmul_1.s"" exited with code -1073741819. [F:\vcpkg\buildtrees\gmp\x86-windows-rel\adcc6b3cc4-2b6258d695\SMP\libgmp.vcxproj]

Neumann-A · 2020-05-09T23:01:04Z

Elapsed time for package vs-yasm:x86-windows: 1.119 s
Starting package 2/2: gmp:x86-windows
Building package gmp[core]:x86-windows...
-- Using cached D:/vcpkg_common/downloads/ShiftMediaProject-gmp-e140dfc8668e96d7e56cbd46467945adcc6b3cc4.tar.gz
-- Using source at D:/vpkg/buildtrees/gmp/src/adcc6b3cc4-2b6258d695
-- Building SMP/libgmp.sln for Release
-- Building SMP/libgmp.sln for Debug
-- Installing: D:/vpkg/packages/gmp_x86-windows/share/gmp/copyright
-- Fixing pkgconfig
-- Fixing pkgconfig - release
-- Checking file: D:/vpkg/packages/gmp_x86-windows/lib/pkgconfig/gmp.pc
-- Checking file: D:/vpkg/packages/gmp_x86-windows/lib/pkgconfig/gmpxx.pc
-- Fixing pkgconfig - debug
-- Checking file: D:/vpkg/packages/gmp_x86-windows/debug/lib/pkgconfig/gmp.pc
-- REL PATH: ../../
-- Checking file: D:/vpkg/packages/gmp_x86-windows/debug/lib/pkgconfig/gmpxx.pc
-- REL PATH: ../../
-- Fixing pkgconfig --- finished
-- Performing post-build validation
-- Performing post-build validation done
Building package gmp[core]:x86-windows... done
Installing package gmp[core]:x86-windows...
Installing package gmp[core]:x86-windows... done
Elapsed time for package gmp:x86-windows: 1.297 min

Total elapsed time: 1.316 min

No issue here from a clean vcpkg directory. Please delete the old buildtree?.

JackBoosY · 2020-05-11T02:07:57Z

@Neumann-A Clone vcpkg in the new directory and run the same command result: same error.

strega-nil · 2020-05-11T17:15:12Z

@Neumann-A I'm having the same error, fwiw

strega-nil · 2020-05-11T17:23:20Z

@Neumann-A looks like yasm is segfaulting

Neumann-A · 2020-05-11T18:07:30Z

Hmmm interesting. I went to my Laptop and had the same problem.
I then updated Visual Studio 2019, Git for Windows and Windows itself with the latest update, restarted and now the failure is gone.
So maybe update your tools? Cannot really help here since I only could reproduce the failure once.

strega-nil · 2020-05-11T20:09:39Z

that is... really odd. However, it did work after updating my tools.

JackBoosY · 2020-05-12T09:52:23Z

This issue blocked my PR #10767.

Neumann-A · 2020-05-12T09:56:23Z

Which VS version is running on CI?

JackBoosY · 2020-05-13T06:05:18Z

When using Visual Studio 2019 to build gmp, the error disappeared.

Neumann-A and others added 15 commits January 31, 2020 14:58

add new function vcpkg_fixup_pkgconfig

df57a82

make message with changed files a debug_message

8c89d6e

add two more cases to the debug *.pc files

fd3d35d

comment out prefix.

1b1d944

use --define-variable=prefix=INSTALL_PATH

changed the comment header.

d7e2962

add missing word

f4bfe74

Merge branch 'master' into add_vcpkg_fixup_pkgconfig

982c921

finish vcpkg_fixup_pkgconfig.cmake

3e0dd50

Update vcpkg_fixup_pkgconfig.cmake

a3d4a0b

Note: since CMake is run in script mode the description of VCPKG_FIXUP_PKGCONFIG_CALLED cannot be viewed

transfer changes from x windows pr

efbf912

fix typo in regex

a7c6c6c

add port for vs yasm integration within VCPKG

9307095

add gmp

2a217d6

add nettle

417dd8a

Merge remote-tracking branch 'origin/add_vcpkg_fixup_pkgconfig' into …

42bb403

…add_gmp_nettle

JackBoosY assigned PhoebeHui and JackBoosY Mar 31, 2020

Neumann-A added 2 commits March 31, 2020 08:05

add missing windows flag in control

5588d48

CI workaround

193fbca

CI seems to not pass env YASMPATH correctly to cl. Since YASM is on PATH -> remove $(VCInstallDir) as the default for YasmPath

Neumann-A added 9 commits March 31, 2020 11:25

overwrite correct import.

6885beb

If CI does not give logs just display some extra info

181af65

target replacement was mising

7866712

apply same replacements for nettle

f9a8227

remove unnecessary status message

76fbdcb

remove unnecessary platform code

51e7188

update supports field for vs-yasm

13ea5b8

apply replacement also to libhogweed

af66ddd

fix static builds

6bae44d

Neumann-A marked this pull request as draft April 9, 2020 18:24

JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Apr 10, 2020

Neumann-A added 2 commits April 29, 2020 14:29

Merge remote-tracking branch 'upstream/master' into add_gmp_nettle

efb0a62

# Conflicts: # scripts/cmake/vcpkg_fixup_pkgconfig.cmake

add missing vcpkg_fixup_pkgconfig() call

54d0c92

Neumann-A marked this pull request as ready for review April 29, 2020 12:31

Merge remote-tracking branch 'upstream/master' into add_gmp_nettle

0c68692

JackBoosY mentioned this pull request May 8, 2020

[libqcow] Update baseline #11238

Merged

JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 8, 2020

strega-nil merged commit 18ab200 into microsoft:master May 8, 2020

Neumann-A deleted the add_gmp_nettle branch May 8, 2020 21:02

Neumann-A mentioned this pull request May 14, 2020

[nettle] Fix nettle version #11336

Closed

JackBoosY mentioned this pull request May 19, 2020

QoL: Buildtype variables for looping over buildtypes #7733

Closed

2 tasks

JackBoosY mentioned this pull request Jul 8, 2020

[nettle:x64-windows] build failure #12240

Open

StarGate-One mentioned this pull request Sep 21, 2020

[vcpkg] use x64 (64-bit) compiler/linker/utilities and tools when building x64 triplets on windows #13642

Closed

wrobelda mentioned this pull request Oct 12, 2021

[shiftmedia-gnutls] new port (Windows fork of GnuTLS) #18029

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[gmp,nettle,hogweed] Add new ports #10613

[gmp,nettle,hogweed] Add new ports #10613

Neumann-A commented Mar 30, 2020 •

edited

Loading

Neumann-A commented Mar 31, 2020

MVoz commented Mar 31, 2020

Neumann-A commented Apr 9, 2020

Neumann-A commented May 7, 2020

JackBoosY commented May 8, 2020

azure-pipelines bot commented May 8, 2020

strega-nil commented May 8, 2020

JackBoosY commented May 9, 2020

Neumann-A commented May 9, 2020

JackBoosY commented May 11, 2020

strega-nil commented May 11, 2020

strega-nil commented May 11, 2020

Neumann-A commented May 11, 2020

strega-nil commented May 11, 2020

JackBoosY commented May 12, 2020

Neumann-A commented May 12, 2020

JackBoosY commented May 13, 2020

[gmp,nettle,hogweed] Add new ports #10613

[gmp,nettle,hogweed] Add new ports #10613

Conversation

Neumann-A commented Mar 30, 2020 • edited Loading

Neumann-A commented Mar 31, 2020

MVoz commented Mar 31, 2020

Neumann-A commented Apr 9, 2020

Neumann-A commented May 7, 2020

JackBoosY commented May 8, 2020

azure-pipelines bot commented May 8, 2020

strega-nil commented May 8, 2020

JackBoosY commented May 9, 2020

Neumann-A commented May 9, 2020

JackBoosY commented May 11, 2020

strega-nil commented May 11, 2020

strega-nil commented May 11, 2020

Neumann-A commented May 11, 2020

strega-nil commented May 11, 2020

JackBoosY commented May 12, 2020

Neumann-A commented May 12, 2020

JackBoosY commented May 13, 2020

Neumann-A commented Mar 30, 2020 •

edited

Loading