Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shiva-sfml]Fix config error and build error #10744

Closed
wants to merge 1 commit into from
Closed

[shiva-sfml]Fix config error and build error #10744

wants to merge 1 commit into from

Conversation

Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W commented Apr 8, 2020

Fixes issue #9116

  1. shiva-sfml installation failed with cmake error: Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE), add PYTHON_EXECUTABLE to fix this issue.
  2. After above issue fixed, shiva-sfml build failed with error: missing sol/xxxxx include files. These files should be generated when sol2 installed, so fix this error in sol2\portfile.cmake.
  3. Add homepage to shiva-sfml.
  4. Remove the deprecated function and blank line.

@Cheney-W Cheney-W added wip info:internal This PR or Issue was filed by the vcpkg team. labels Apr 8, 2020
@Cheney-W Cheney-W closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LilyWangL LilyWangL

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cheney-W @strega-nil @LilyWangL