Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asio] Update to 1.16.1 #11128

Closed
wants to merge 2 commits into from
Closed

Conversation

podsvirov
Copy link
Contributor

No description provided.

@c72578
Copy link
Contributor

c72578 commented May 2, 2020

Please remove include(vcpkg_common_functions), it is deprecated.

@podsvirov
Copy link
Contributor Author

Please remove include(vcpkg_common_functions), it is deprecated.

Done.

@LilyWangL LilyWangL self-requested a review May 6, 2020 01:57
@LilyWangL LilyWangL self-assigned this May 6, 2020
@LilyWangL
Copy link
Contributor

Thanks for your PR. Ports restbed and opendnp3 depend on asio, now they build failed due to asio update to 1.16.1. Could you continue to fix this PR? You can click Details to get more information form CI test.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL
Copy link
Contributor

@podsvirov Could you continue to fix this PR?

@podsvirov
Copy link
Contributor Author

Looks like the restbed still not ready for such a change. I created ISSUE to discuss this topic.

@podsvirov
Copy link
Contributor Author

podsvirov commented May 14, 2020

Looks like the opendnp3 still not ready for such a change. I created ISSUE to discuss this topic.

UPDATE: Problem already fixed in develop branch. We are waiting for a new release. Or someone can port back the necessary changes. I don’t want to do this.

@JackBoosY JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label May 22, 2020
@LilyWangL LilyWangL added the category:port-update The issue is with a library, which is requesting update new revision label Jul 17, 2020
@BillyONeal
Copy link
Member

@podsvirov It looks like dnp3/opendnp3#373 is now fixed, are you still interested in this?

@BillyONeal BillyONeal added requires:author-response and removed depends:upstream-changes Waiting on a change to the upstream project labels Aug 18, 2020
@podsvirov
Copy link
Contributor Author

podsvirov commented Aug 19, 2020

Hello @BillyONeal, I'm here. Interest has not faded yet :-)
Are you suggesting to update the associated ports in this PR?
UPDATE: Why merge the master branch into the feature branch of the unfinished pull request? I prefer to rebase changes before the merge time.

@BillyONeal
Copy link
Member

Hello @BillyONeal, I'm here. Interest has not faded yet :-)

Sounds good, just saw that the dependent issue had been resolved and wanted to double check

Are you suggesting to update the associated ports in this PR?

If that's necessary to make it build correctly. We can't merge it while we know it breaks the tree.

UPDATE: Why merge the master branch into the feature branch of the unfinished pull request? I prefer to rebase changes before the merge time.

I wanted the PR system to retest the changes because I wasn't sure if the old failures were spurious.

@BillyONeal
Copy link
Member

UPDATE: Why merge the master branch into the feature branch of the unfinished pull request? I prefer to rebase changes before the merge time.

I wanted the PR system to retest the changes because I wasn't sure if the old failures were spurious.

That is: feel free to drop that commit on rebase. When we merge this it would be squashed anyway. :)

@LilyWangL
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

@LilyWangL LilyWangL closed this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants