[ignition-common3] Add new port 🤖 #11273

traversaro · 2020-05-09T15:50:22Z

What does your PR fix?
- This PR adds a new port for the new major version of the ignition-common library.
Which triplets are supported/not supported?
- All tested triplet (for which the dependency are actually available) should be supported.
Does your PR follow the maintainer guide?
- I hope.

As discussed in #7781, different major version of ignition robotics libraries (https://ignitionrobotics.org/) can be installed side by side, so each new major version is added as a new port.

In particular, ignition-common3 is a dependency for Gazebo 11 (http://gazebosim.org/blog/gazebo11) and for Ignition Robotics Citadel (that contains Ignition Gazebo 3, see https://www.openrobotics.org/blog/2019/12/11/ignition-citadel-released).

PhoebeHui

LGTM, thanks for the PR!

ports/ignition-common3/CONTROL

PhoebeHui · 2020-05-12T09:27:37Z

@traversaro, thanks for quick updates!

I noticed ignition-common3:x64-linux failed on linux CI testing, could you have a look?

CMake Error at /mnt/1/s/installed/x64-linux/share/cmake/ignition-cmake2/cmake2/IgnConfigureBuild.cmake:66 (message):
Errors encountered in build. Please see BUILD ERRORS above.
Call Stack (most recent call first):
CMakeLists.txt:120 (ign_configure_build)

config-x64-linux-dbg-err.log
config-x64-linux-dbg-out.log

TrentWeiss · 2020-05-14T19:09:03Z

Something I have noticed:

This port doesn't properly install the cmake config files for ignition-common3's various subcomponents, ( "graphics", "profiler", etc). I.e. the various -config.cmake and -config-version.cmake never make it to the vcpkg installation directory. However, the actual library files do get built and installed.

for example:
C:\path\to\vcpkginstalldir\lib\ignition-common3-graphics.lib is present after the install finishes, but the corresponding cmake config file that tells cmake where to find it does not.
I.e. C:\path\to\vcpkginstalldir\share\ignition-common3\ignition-common3-graphics-config.cmake doesn't exist. If you try to do a find_package for ignition-common3 with graphics specified as a component such as the following:
find_package(ignition-common3 CONFIG REQUIRED
COMPONENTS
graphics
)
The find_package call will fail, even though the library was technically built. For example, if you tried to build Gazebo11 (which I strongly sense is the motivation for this port), the config stage will not work. The cmake configuration of Gazebo will THINK ignition-common3-graphics doesn't exist, because the config file for it is nowhere to be found.

traversaro · 2020-05-16T09:31:34Z

The find_package call will fail, even though the library was technically built. For example, if you tried to build Gazebo11 (which I strongly sense is the motivation for this port), the config stage will not work. The cmake configuration of Gazebo will THINK ignition-common3-graphics doesn't exist, because the config file for it is nowhere to be found.

Thanks for the comment. For the moment I am actually building Gazebo11 by building all the ignition related dependencies with colcon (see https://github.com/robotology/robotology-superbuild-dependencies-vcpkg/blob/v0.3.0/.github/workflows/ci.yml#L171), but indeed the main motivation of brinding all the libraries to vcpkg is to be able to avoid to rely on colcon.

TrentWeiss · 2020-05-16T12:41:40Z

Thanks for the comment. For the moment I am actually building Gazebo11 by building all the ignition related dependencies with colcon (see https://github.com/robotology/robotology-superbuild-dependencies-vcpkg/blob/v0.3.0/.github/workflows/ci.yml#L171), but indeed the main motivation of brinding all the libraries to vcpkg is to be able to avoid to rely on colcon.

Haha I am currently doing the exact same thing and would also like to avoid having to maintain a custom build of Gazebo with colcon.

traversaro · 2020-05-16T15:03:35Z

@traversaro, thanks for quick updates!

I noticed ignition-common3:x64-linux failed on linux CI testing, could you have a look?

CMake Error at /mnt/1/s/installed/x64-linux/share/cmake/ignition-cmake2/cmake2/IgnConfigureBuild.cmake:66 (message):
Errors encountered in build. Please see BUILD ERRORS above.
Call Stack (most recent call first):
CMakeLists.txt:120 (ign_configure_build)

config-x64-linux-dbg-err.log
config-x64-linux-dbg-out.log

I pushed an updated version of the branch that should fix it by backporting the ignition-cmake PR gazebosim/gz-cmake#95 .

traversaro · 2020-05-16T16:24:05Z

Something I have noticed: [...]

This has been fixed in #11275 , and the fix will automatically work also for the ignition-common3 port as soon as that PR is merged.

traversaro · 2020-05-31T06:31:40Z

Hi @PhoebeHui , as I see this PR listed under "requires:author-response", if there is anything else that needs my input feel free to ask, thanks!

seanyen · 2020-06-06T04:59:04Z

wow, looks like we are about to get all deps for Gazebo11. 😉

traversaro · 2020-06-06T08:44:06Z

PR rebased over latest master, and all the changes requested by the reviewer have been addressed.

traversaro · 2020-06-06T08:54:11Z

There are a few failures in the x64-linux triplet, in particular it is not able to find anymore uuid, FreeImage and gts :

-- BUILD WARNINGS
-- 	Cannot build component [graphics] - Missing: FreeImage
-- 	Cannot build component [graphics] - Missing: gts - GNU Triangulation Surface library
-- END BUILD WARNINGS

-- BUILD ERRORS: These must be resolved before compiling.
-- 	Missing: uuid
-- END BUILD ERRORS

CMake Error at /mnt/vcpkg-ci/install/x64-linux/share/cmake/ignition-cmake2/cmake2/IgnConfigureBuild.cmake:66 (message):
  Errors encountered in build.  Please see BUILD ERRORS above.
Call Stack (most recent call first):
  CMakeLists.txt:120 (ign_configure_build)

I guess this is probably due to the fact that now pkg-config is installed in CI machines, and the .pc files installed by those ports are not correct/well formed.

traversaro · 2020-06-06T10:17:09Z

There are a few failures in the x64-linux triplet, in particular it is not able to find anymore uuid, FreeImage and gts :
-- BUILD WARNINGS
-- 	Cannot build component [graphics] - Missing: FreeImage
-- 	Cannot build component [graphics] - Missing: gts - GNU Triangulation Surface library
-- END BUILD WARNINGS

-- BUILD ERRORS: These must be resolved before compiling.
-- 	Missing: uuid
-- END BUILD ERRORS

CMake Error at /mnt/vcpkg-ci/install/x64-linux/share/cmake/ignition-cmake2/cmake2/IgnConfigureBuild.cmake:66 (message):
  Errors encountered in build.  Please see BUILD ERRORS above.
Call Stack (most recent call first):
  CMakeLists.txt:120 (ign_configure_build)
I guess this is probably due to the fact that now pkg-config is installed in CI machines, and the .pc files installed by those ports are not correct/well formed.

Actually there was a missing dependency in the CONTROL file. This should have been fixed in the last commit.

traversaro · 2020-06-07T13:16:43Z

I also backported gazebosim/gz-common#71 to avoid having Windows failures. There is still a x64_osx failure, but it is not related to the PR. Windows CI still fails, but with the unrelated failure in the port qscintilla:x86-windows .

traversaro · 2020-06-07T14:28:10Z

The linux failure is due to #11817, so for now I just updated the baseline.

traversaro · 2020-08-01T09:49:47Z

that again seems something that will be solved by #12326, that itself is blocked by #11550 and #11776 .

Status update:

[vcpkg/scripts/pkgconfig] rewrite pkg-config check for libraries #11550 has been merged
[intl/gettext/fontconfig] update to native build system #11776 still needs to be merged, blocked by [vcpkg/scripts/make] trying to iron out some issues #11836 and [brotli] add pkgconfig / [freetype] depend on brotli #12405
[glib/gtk/atk] Add pkgconfig file #12326 still needs to be merged, blocked by [intl/gettext/fontconfig] update to native build system #11776

traversaro · 2020-09-05T08:56:35Z

that again seems something that will be solved by #12326, that itself is blocked by #11550 and #11776 .

Status update:
* #11550 has been merged

* #11776 still needs to be merged, blocked by #11836 and #12405

* #12326 still needs to be merged, blocked by #11776

Status update:

[intl/gettext/fontconfig] update to native build system #11776 still needs to be merged, now blocked by [vcpkg/scripts] Add a way to get cmake compiler settings/flags #12936
[glib/gtk/atk] Add pkgconfig file #12326 still needs to be merged, still blocked by [intl/gettext/fontconfig] update to native build system #11776

traversaro · 2020-10-07T15:19:21Z

I opened a separate issue for the ffmpeg/.pc files problem as it is not trivial: #12376 .

This will be fixed (hopefully) by #13919 .

traversaro · 2020-10-11T10:52:32Z

Status update:

[intl/gettext/fontconfig] update to native build system #11776 still needs to be merged, still blocked by [vcpkg/scripts] Add a way to get cmake compiler settings/flags #12936
[glib/gtk/atk] Add pkgconfig file #12326 still needs to be merged, still blocked by [intl/gettext/fontconfig] update to native build system #11776
[ffmpeg] Use vcpkg_fixup_pkgconfig. #13919 still needs to be merged, possibly blocked by [vcpkg_fixup_pkgconfig] Handle spaces in path, do not validate individual libraries #13126 and [X Window System] add libraries for the x window systems #9966 depending on the outcome of the discussion in the PR

traversaro · 2020-11-28T14:03:59Z

Status update:

* #11776 still needs to be merged, still blocked by #12936

* #12326 still needs to be merged, still blocked by #11776

* #13919 still needs to be merged, possibly blocked by #13126 and #9966 depending on the outcome of the discussion in the PR

New status update:

[intl/gettext/fontconfig] update to native build system #11776 merged!
[glib/gtk/atk] Add pkgconfig file #12326 still needs to be merged, it is not blocked by any other PR
[ffmpeg] Use vcpkg_fixup_pkgconfig. #13919 still needs to be merged, possibly blocked by [vcpkg_fixup_pkgconfig] Handle spaces in path, do not validate individual libraries #13126 and [X Window System] add libraries for the x window systems #9966 depending on the outcome of the discussion in the PR

traversaro · 2020-12-27T11:50:14Z

Status updated:

Cleanup the PR as several changes are not necessary anymore due to updated to ignition ports
Bumped used version to 3.9.0

#13919 still needs to be merged, possibly blocked by #13126 and #9966 depending on the outcome of the discussion in the PR

This was superseded by #15127 .

The Linux CI is now blocked by #15326, that I guessed could be solved by #12326 but probably can be solved also by other glib-related PRs.

traversaro · 2021-01-02T23:42:49Z

Thanks to #15360, the PR is now passing all the CI tests and is now ready for review @PhoebeHui .

fyi @seanyen @ahoarau

ports/ignition-common3/portfile.cmake

Co-authored-by: Phoebe <[email protected]>

PhoebeHui

Thanks for your updates!

vicroms · 2021-01-05T19:57:31Z

Thanks for the PR!

traversaro changed the title ~~[ignition-common3] Add new port~~ [ignition-common3] Add new port 🤖 May 9, 2020

traversaro force-pushed the add-ignition-common3 branch from 01a7635 to aae7377 Compare May 9, 2020 15:54

PhoebeHui self-assigned this May 11, 2020

PhoebeHui approved these changes May 12, 2020

View reviewed changes

PhoebeHui requested changes May 12, 2020

View reviewed changes

ports/ignition-common3/CONTROL Outdated Show resolved Hide resolved

PhoebeHui added the waiting for response label May 12, 2020

traversaro force-pushed the add-ignition-common3 branch from 96416df to 41bf8a6 Compare May 12, 2020 22:17

traversaro force-pushed the add-ignition-common3 branch from 41bf8a6 to deeb523 Compare May 16, 2020 15:02

traversaro force-pushed the add-ignition-common3 branch from deeb523 to 1b3bc3d Compare May 16, 2020 15:06

traversaro mentioned this pull request May 16, 2020

[ignition-plugin1] Add new port 🤖 #11275

Merged

traversaro mentioned this pull request May 18, 2020

Add support for finding several dependencies without pkg-config gazebosim/gz-cmake#95

Merged

traversaro force-pushed the add-ignition-common3 branch from 1b3bc3d to b022625 Compare June 6, 2020 08:43

traversaro mentioned this pull request Jun 6, 2020

[gts] Provide .pc pkg-config files #11808

Closed

traversaro force-pushed the add-ignition-common3 branch from b022625 to 9f7dc44 Compare June 6, 2020 10:16

traversaro force-pushed the add-ignition-common3 branch from 9f7dc44 to ee88ccb Compare June 7, 2020 13:15

traversaro force-pushed the add-ignition-common3 branch from ee88ccb to 74a56f1 Compare June 7, 2020 13:45

traversaro force-pushed the add-ignition-common3 branch from 74a56f1 to 3118e16 Compare June 7, 2020 14:32

PhoebeHui assigned LilyWangL Aug 10, 2020

LilyWangL removed the requires:author-response label Sep 8, 2020

traversaro mentioned this pull request Sep 9, 2020

Use upstream releases of Ignition instead of specific checkouts and forks robotology/robotology-superbuild-dependencies-vcpkg#26

Closed

traversaro mentioned this pull request Oct 11, 2020

Jenkins Windows CI is not installing DART gazebosim/gz-physics#87

Open

LilyWangL marked this pull request as draft October 27, 2020 08:17

This was referenced Oct 31, 2020

[ignition] Updates on various pkgs 🤖 #14324

Merged

AV component not being tested on Windows gazebosim/gz-common#122

Closed

traversaro force-pushed the add-ignition-common3 branch from ed2d692 to dc43942 Compare December 27, 2020 11:11

traversaro mentioned this pull request Dec 27, 2020

[glib] glib-2.0 .pc file contains non-existing include directory #15326

Closed

[ignition-common3] Add new port

28aaad0

traversaro force-pushed the add-ignition-common3 branch from e9f95a8 to 28aaad0 Compare January 2, 2021 23:19

traversaro marked this pull request as ready for review January 2, 2021 23:41

PhoebeHui requested changes Jan 5, 2021

View reviewed changes

ports/ignition-common3/portfile.cmake Outdated Show resolved Hide resolved

PhoebeHui added requires:author-response and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Jan 5, 2021

Update ports/ignition-common3/portfile.cmake

46f18c8

Co-authored-by: Phoebe <[email protected]>

PhoebeHui removed the requires:author-response label Jan 5, 2021

PhoebeHui approved these changes Jan 5, 2021

View reviewed changes

PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jan 5, 2021

vicroms merged commit d2e0939 into microsoft:master Jan 5, 2021

traversaro mentioned this pull request Jan 11, 2021

Add irrlicht, update vcpkg and install ignition libraries via vcpkg robotology/robotology-superbuild-dependencies-vcpkg#39

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ignition-common3] Add new port 🤖 #11273

[ignition-common3] Add new port 🤖 #11273

traversaro commented May 9, 2020

PhoebeHui left a comment

PhoebeHui commented May 12, 2020 •

edited

Loading

TrentWeiss commented May 14, 2020

traversaro commented May 16, 2020

TrentWeiss commented May 16, 2020

traversaro commented May 16, 2020

traversaro commented May 16, 2020 •

edited

Loading

traversaro commented May 31, 2020

seanyen commented Jun 6, 2020

traversaro commented Jun 6, 2020

traversaro commented Jun 6, 2020

traversaro commented Jun 6, 2020

traversaro commented Jun 7, 2020 •

edited

Loading

traversaro commented Jun 7, 2020

traversaro commented Aug 1, 2020

traversaro commented Sep 5, 2020

traversaro commented Oct 7, 2020

traversaro commented Oct 11, 2020

traversaro commented Nov 28, 2020

traversaro commented Dec 27, 2020

traversaro commented Jan 2, 2021 •

edited

Loading

PhoebeHui left a comment

vicroms commented Jan 5, 2021

[ignition-common3] Add new port 🤖 #11273

[ignition-common3] Add new port 🤖 #11273

Conversation

traversaro commented May 9, 2020

PhoebeHui left a comment

Choose a reason for hiding this comment

PhoebeHui commented May 12, 2020 • edited Loading

TrentWeiss commented May 14, 2020

traversaro commented May 16, 2020

TrentWeiss commented May 16, 2020

traversaro commented May 16, 2020

traversaro commented May 16, 2020 • edited Loading

traversaro commented May 31, 2020

seanyen commented Jun 6, 2020

traversaro commented Jun 6, 2020

traversaro commented Jun 6, 2020

traversaro commented Jun 6, 2020

traversaro commented Jun 7, 2020 • edited Loading

traversaro commented Jun 7, 2020

traversaro commented Aug 1, 2020

traversaro commented Sep 5, 2020

traversaro commented Oct 7, 2020

traversaro commented Oct 11, 2020

traversaro commented Nov 28, 2020

traversaro commented Dec 27, 2020

traversaro commented Jan 2, 2021 • edited Loading

PhoebeHui left a comment

Choose a reason for hiding this comment

vicroms commented Jan 5, 2021

PhoebeHui commented May 12, 2020 •

edited

Loading

traversaro commented May 16, 2020 •

edited

Loading

traversaro commented Jun 7, 2020 •

edited

Loading

traversaro commented Jan 2, 2021 •

edited

Loading