-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[threadpool] Add new port #11650
[threadpool] Add new port #11650
Conversation
What is the actual failure from CI? The only information it says is:
But what is the actual failure? It doesn't say. I've tried using this library on the |
|
Probably should print a warning that the this implementation is not NUMA aware ;) and will only support <64 logical cores on windows |
@Neumann-A Thanks. I force pushed an identical commit to retrigger the CI because I thought it might be an intermittent network failure. And still, the file downloads fine for all the triplets except The file downloads fine here via the browser and via How do I even debug this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a header-only library? It seems just some headers are added.
Co-authored-by: NancyLi1013 <[email protected]>
@NancyLi1013 Yep, this library is header-only. |
So how do I mark the requested review changes as accepted and remove the |
Sorry for the late response. The labels can only be removed by our team members. We will remove it if there are no any changes needed to be done. |
@NancyLi1013 Okay, thanks. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks! |
I don't need this anymore personally because the code that used this library turned out to be unreachable. 😣 Maybe someone else will find it useful though. |
Adds a port for the threadpool library.
Fixes #9735