-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Add vcpkg_from_sourceforge (1/2) #11899
[vcpkg] Add vcpkg_from_sourceforge (1/2) #11899
Conversation
@Neumann-A @voskrese @cenit Could you please review this PR? Thanks. |
apart from one single note, it's a very nice addition IMHO. |
In the next PR, I will add code to retry different mirrors in this function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the only things I see; I would still like to see moving from regex to substring, and printing an error if there's more than one /
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks JacK!
What are the blockers to merging this? Just CI running? |
Just CI |
Yeah, for some reason the previous attempt broke inside Azure Pipelines (some of the machines dropped off the face of the earth) |
Cool :) |
|
||
vcpkg_download_distfile(ARCHIVE | ||
URLS "https://ftp.pcre.org/pub/pcre/pcre2-${PCRE2_VERSION}.zip" "https://sourceforge.net/projects/pcre/files/pcre2/${PCRE2_VERSION}/pcre2-${PCRE2_VERSION}.zip/download" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of pcre2, the primary download server was:
https://ftp.pcre.org/pub/pcre/
This has been removed here by switching to vcpkg_from_sourceforge()
.
The following appears now in artifacts of failed CI-builds [1]:
-- Downloading https://downloads.sourceforge.net/project/pcre/pcre2/10.30/pcre2-10.30.zip... Failed. Status: 7;"Couldn't connect to server"
During the CI-build of commit a0bd59c it occurred two times (pcre2:x64-windows and pcre2:x64-uwp).
Is there a possibility to have a different download server like https://ftp.pcre.org/pub/pcre/ also when using vcpkg_from_sourceforge()
? Otherwise the previous vcpkg_download_distfile()
used for pcre2 would be more reliable.
[1] https://dev.azure.com/vcpkg/public/_build/results?buildId=39415&view=results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take a look later. Thank's for notice that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JackBoosY Thanks. The PR #12018 can improve the situation concerning downloads from sourceforge and sourceforge mirrors. However, it does not compensate the removal of different, independent download sources like https://ftp.pcre.org/pub/pcre/ etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BillyONeal, yes #12233 LGTM. It primarily uses the original download server and as an alternative possibility the improved download from sourceforge.
There are 43 ports in vcpkg downloaded using sourceforge.
Adding a unified download method is convenient for modifying the download method of the sourceforge storage port in the future.
Related: #11502.