-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Add mingw dynamic libs triplet #12101
[vcpkg] Add mingw dynamic libs triplet #12101
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The only concern I have is that this PR changes the behavior of already existing triplets for MinGW, and will break users that have already adopted those triplets. |
I think a good compromise is to rename both triplets: |
So |
I say we remove |
Thanks for the PR! |
Describe the pull request
What does your PR fix? Fixes #
This PR adds 4 triplets for building dynamic libs with
mingw
toolchain, and rename the old static libs triplets to*-static
, following the*-windows
triplets conventionCurrently, building with this triplet will fail, due to the post-build validation only checking forAdded.lib
files, not.dll.a
files, but the building process seems to be ok, at least for CMake-based libs. So we only have that left to fix.VCPKG_POLICY_DLLS_WITHOUT_LIBS
as a workaround.Which triplets are supported/not supported? Have you updated the CI baseline?
Should be all
*-mingw
triplets, but I've only testedx64-mingw
Does your PR follow the maintainer guide?
Yes