Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Improve format check failure message #12460

Merged
merged 5 commits into from
Jul 30, 2020
Merged

[vcpkg] Improve format check failure message #12460

merged 5 commits into from
Jul 30, 2020

Conversation

JackBoosY
Copy link
Contributor

Related: #12423.

@JackBoosY JackBoosY added category:documentation To resolve the issue, documentation will need to be updated info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Jul 17, 2020
@PhoebeHui PhoebeHui changed the title Improve format check failure message [vcpkg] Improve format check failure message Jul 17, 2020
@strega-nil
Copy link
Contributor

I really want to print the diff in a readable way; I think Write-Host the diff, then throw might work?

@JackBoosY
Copy link
Contributor Author

@strega-nil In fact, the difference is printed in the error message now, but it hard to see.
The best way is commit the correct file to archive automatically, then contributor can download it and commit to branch, but it out of my scope.

@JackBoosY JackBoosY marked this pull request as ready for review July 20, 2020 05:53
@JackBoosY JackBoosY mentioned this pull request Jul 20, 2020
Closed
@JackBoosY JackBoosY requested a review from ras0219-msft July 22, 2020 02:13
@strega-nil strega-nil merged commit d367c4c into microsoft:master Jul 30, 2020
@JackBoosY JackBoosY deleted the dev/jack/improve_format_check_msg branch July 30, 2020 05:35
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jul 30, 2020
@Jimmy-Hu
Merge pull request #266 from microsoft/master
7987408 
[vcpkg] Improve format check failure message (microsoft#12460)
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@JackBoosY @hellozee
[vcpkg] Improve format check failure message (microsoft#12460)
8009092 
* [docs] Add format document

* improve the error message

* Check the error message

* Finish test

* restore file list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@PhoebeHui PhoebeHui

Labels
category:documentation To resolve the issue, documentation will need to be updated category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @strega-nil @ras0219-msft @PhoebeHui