[vcpkg-acquire-msys] Install new keyring #12467

emptyVoid · 2020-07-17T17:56:05Z

Describe the pull request
Adjusts vcpkg_acquire_msys script to install the new keyring (see MSYS2 News).

What does your PR fix?
Fixes Update MSYS2 base #12288
Which triplets are supported/not supported? Have you updated the CI baseline?
N/A
Does your PR follow the maintainer guide?
Yes

MVoz · 2020-07-17T22:42:40Z

in my opinion this option is better

rm -r /etc/pacman.d/gnupg/
pacman-key --init
pacman-key --populate

elieux · 2020-07-20T17:02:12Z

in my opinion this option is better

rm -r /etc/pacman.d/gnupg/
pacman-key --init
pacman-key --populate

Better than what? Your commands don't install the new keys (we're starting with a clean 20190524 installation).

MVoz · 2020-07-20T17:08:32Z

@elieux https://www.msys2.org/news/#2020-06-29-new-packagers

2020-06-29-new-packagers

If you still see signature errors, resetting your pacman key store might help:

rm -r /etc/pacman.d/gnupg/
pacman-key --init
pacman-key --populate msys2

@elieux 2020-06-29-new-packagers

elieux · 2020-07-20T17:36:32Z

Yes, but this makes sense only after the new keyring is installed. It's not either/or, it's "do the first step, then maybe the second one".

MVoz · 2020-07-20T18:33:27Z

Yes what? what do you mean in General?
if the distribution is outdated and the keys do not fit and are not updated, then they must be deleted and updated before installing the packages\utilities

elieux · 2020-07-20T18:59:10Z

Yes what?

Yes, I wrote those steps. But I don't think you understand when to use them.

they must be deleted and updated before installing the packages\utilities

No need to delete. Update is taken care of by installing the new keyring (which this PR is about). See also https://github.com/msys2/MSYS2-packages/blob/master/msys2-keyring/msys2-keyring.install.

MVoz · 2020-07-20T19:06:22Z

But I don't think you understand when to use them.

good luck to you, you are so smart 😂

elieux · 2020-07-20T20:05:40Z

@voskrese, it wasn't meant as a conversation stopper. If you have reasons to believe nuking the GPG directory is necessary, please state them.

@LilyWangL, what kind of discussion is expected ("required") here?

MVoz · 2020-07-21T00:24:55Z

@elieux

I think you take a lot on yourself, this error occurred only to you, you may have edited the settings files incorrectly

old version work

new version work

vcpkg_acquire_msys

elieux · 2020-07-24T21:26:23Z

Just letting you know we have uploaded a new msys-x86_64 database, signed with a new key. mingw databases will probably follow.

yasamoka · 2020-07-24T22:01:09Z

@elieux
I think you take a lot on yourself, this error occurred only to you, you may have edited the settings files incorrectly
old version work
new version work
vcpkg_acquire_msys

No … this didn't occur only to him …

The exact same error just occurred to me now. Fresh clone of vcpkg, installing packages from scratch.

There is no configuration that I could have messed up as I didn't even do anything beyond bootstrapping and installing some packages.

I would tone down the attitude, read well, and urge to fix this as fast as possible if I were you.

coryan · 2020-07-24T22:04:39Z

Looking forward to this fix myself, I cannot use vcpkg right now either.

yasamoka · 2020-07-25T03:04:45Z

Given I am facing this issue and no solution except the following (mentioned here) is working for me:

... you have to convince pacman to not care about those databases for a while, for example like this:

# pacman -U --config <(echo) msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz

With my limited understanding of this sort of work, I have added a workaround here based on this pull request. Feel free to use it if you urgently need to use vcpkg to build packages that rely on MSYS in the meantime.

As usual with these sorts of workarounds, I take no responsibility for any consequences arising out of using this. This is strictly temporary.

c72578 · 2020-07-25T09:56:31Z

@emptyVoid Could you please check, if this PR still fixes the issue?
I just did some tests under Windows 10 with installed VS2019 and using a clean, up-to-date vcpkg including this PR.
The error below appears, when building bzip2.

git clone https://github.com/microsoft/vcpkg.git
cd .\vcpkg\
git fetch origin pull/12467/head:PR_12467
git checkout PR_12467
git rebase master
Successfully rebased and updated refs/heads/PR_12467.
.\bootstrap-vcpkg.bat
.\vcpkg.exe install bzip2:x64-windows
...

Error:

...
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Fixing pkgconfig
-- Acquiring MSYS2...
-- Downloading https://sourceforge.net/projects/msys2/files/Base/x86_64/msys2-base-x86_64-20190524.tar.xz/download...
-- Downloading http://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz...
-- Downloading http://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig...
gpg: /etc/pacman.d/gnupg/trustdb.gpg: trustdb created
gpg: no ultimately trusted keys found
gpg: starting migration from earlier GnuPG versions
gpg: porting secret keys from '/etc/pacman.d/gnupg/secring.gpg' to gpg-agent
gpg: migration succeeded
gpg: Generating pacman keyring master key...
gpg: key 5C587674F90CFE24 marked as ultimately trusted
gpg: directory '/etc/pacman.d/gnupg/openpgp-revocs.d' created
gpg: revocation certificate stored as '/etc/pacman.d/gnupg/openpgp-revocs.d/D3436DA32F8C65745315E2165C587674F90CFE24.rev'
gpg: Done
==> Updating trust database...
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u
==> Appending keys from msys2.gpg...
==> Locally signing trusted keys in keyring...
  -> Locally signing key D55E7A6D7CE9BA1587C0ACACF40D263ECA25678A...
  -> Locally signing key 123D4D51A1793859C2BE916BBBE514E53E0D0813...
  -> Locally signing key B91BCF3303284BF90CC043CA9F418C233E652008...
  -> Locally signing key 9DD0D4217D75A33B896159E6DA7EF2ABAEEA755C...
==> Importing owner trust values...
gpg: setting ownertrust to 4
gpg: setting ownertrust to 4
gpg: setting ownertrust to 4
gpg: inserting ownertrust of 4
==> Updating trust database...
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   1  signed:   4  trust: 0-, 0q, 0n, 0m, 0f, 1u
gpg: depth: 1  valid:   4  signed:   3  trust: 0-, 0q, 0n, 4m, 0f, 0u
gpg: depth: 2  valid:   3  signed:   0  trust: 3-, 0q, 0n, 0m, 0f, 0u
==> Checking vcpkg/downloads/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig...
gpg: assuming signed data in 'vcpkg/downloads/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz'
gpg: Signature made Mon Jun 29 07:36:14 2020 WEDT
gpg:                using DSA key AD351C50AE085775EB59333B5F92EFC1A47D45A1
gpg: Good signature from "Alexey Pavlov (Alexpux) <[email protected]>" [full]
loading packages...
resolving dependencies...
looking for conflicting packages...

Packages (1) msys2-keyring-r21.b39fb11-1

Total Installed Size:  0.05 MiB
Net Upgrade Size:      0.03 MiB

:: Proceed with installation? [Y/n] :: Synchronizing package databases...
downloading mingw32.db...
downloading mingw32.db.sig...
downloading mingw64.db...
downloading mingw64.db.sig...
downloading msys.db...
downloading msys.db.sig...
error: msys: key "4A6129F4E4B84AE46ED7F635628F528CF3053E04" is unknown
error: key "4A6129F4E4B84AE46ED7F635628F528CF3053E04" could not be looked up remotely
error: failed to update msys (invalid or corrupted database (PGP signature))
error: failed to synchronize all databases
error: msys: key "4A6129F4E4B84AE46ED7F635628F528CF3053E04" is unknown
error: key "4A6129F4E4B84AE46ED7F635628F528CF3053E04" could not be looked up remotely
checking dependencies...

Packages (2) rebase-4.4.4-1  dash-0.5.10.2-1

Total Removed Size:  1.12 MiB

:: Do you want to remove these packages? [Y/n]
:: Processing package changes...
removing rebase...
removing dash...
error: msys: key "4A6129F4E4B84AE46ED7F635628F528CF3053E04" is unknown
error: key "4A6129F4E4B84AE46ED7F635628F528CF3053E04" could not be looked up remotely
:: Synchronizing package databases...
 mingw32 is up to date
 mingw64 is up to date
downloading msys.db...
downloading msys.db.sig...
error: msys: key "4A6129F4E4B84AE46ED7F635628F528CF3053E04" is unknown
error: key "4A6129F4E4B84AE46ED7F635628F528CF3053E04" could not be looked up remotely
error: failed to update msys (invalid or corrupted database (PGP signature))
error: failed to synchronize all databases
-- Acquiring MSYS2... OK
-- Acquiring MSYS Packages...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
    Command failed: vcpkg/downloads/tools/msys2/msys64/usr/bin/bash.exe --noprofile --norc -c "pacman -S --noconfirm --needed pkg-config"
    Working Directory: vcpkg/downloads/tools/msys2
    Error code: 1
    See logs for more information:
      vcpkg\buildtrees\bzip2\msys-pacman-x64-windows-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_acquire_msys.cmake:149 (vcpkg_execute_required_process)
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:281 (vcpkg_acquire_msys)
  ports/bzip2/portfile.cmake:51 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:79 (include)

msys-pacman-x64-windows-err.log

scripts/cmake/vcpkg_acquire_msys.cmake

elieux · 2020-07-25T14:42:52Z

scripts/cmake/vcpkg_acquire_msys.cmake

@@ -91,6 +104,15 @@ function(vcpkg_acquire_msys PATH_TO_ROOT_OUT)
      COMMAND ${PATH_TO_ROOT}/usr/bin/bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman-key --init;pacman-key --populate"
      WORKING_DIRECTORY ${TOOLPATH}
    )
+    # install the new keyring
+    _execute_process(
+      COMMAND ${PATH_TO_ROOT}/usr/bin/bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman-key --verify ${KEYRING_SIG_PATH}"


Is the result somehow verified?

Now it checks the error code -- I assume pacman-key returns some non-zero code if verification fails.

elieux · 2020-07-25T15:09:24Z

@c72578, thanks for noticing and reporting this. It didn't occur to me to check for this.

MVoz · 2020-07-26T14:54:06Z

@yasamoka
no need to cheat, just because is a new version and not there can be problems with certificates

emptyVoid · 2020-07-26T14:56:32Z

@c72578, should work now, can you check on your side please?

MVoz · 2020-07-26T14:56:36Z

and in general it is necessary to MSYS to update and provide all possible variants of errors and fix them in advance in the script

c72578 · 2020-07-26T18:36:29Z

@c72578, should work now, can you check on your side please?

Thanks for updating the PR. It is OK now.
I just tested it building bzip2:x64-windows as described above.

JackBoosY · 2020-07-27T08:34:56Z

/azp run

azure-pipelines · 2020-07-27T08:35:05Z

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY · 2020-07-27T08:42:46Z

It seems that the pipeline test is completely broken... needs to fix it.

angelo-peronio · 2020-07-28T09:00:55Z

With my limited understanding of this sort of work, I have added a workaround here based on this pull request. Feel free to use it if you urgently need to use vcpkg to build packages that rely on MSYS in the meantime.

@yasamoka You saved my day, thank you! I used your workaround like this:

cd vcpkg
git remote add msys2-hotfix https://github.com/yasamoka/vcpkg.git
git fetch msys2-hotfix
git cherry-pick abc0b6

yasamoka · 2020-07-28T11:11:25Z

With my limited understanding of this sort of work, I have added a workaround here based on this pull request. Feel free to use it if you urgently need to use vcpkg to build packages that rely on MSYS in the meantime.

@yasamoka You saved my day, thank you! I used your workaround like this:
cd vcpkg
git remote add msys2-hotfix https://github.com/yasamoka/vcpkg.git
git fetch msys2-hotfix
git cherry-pick abc0b6

Glad to have helped! Do note that the latest commits to this PR include the fix, so as soon as the PR gets accepted, we should be good to go.

strega-nil · 2020-07-28T15:39:46Z

/azp run

azure-pipelines · 2020-07-28T15:39:55Z

Azure Pipelines successfully started running 1 pipeline(s).

LilyWangL self-assigned this Jul 20, 2020

LilyWangL added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed requires:discussion labels Jul 20, 2020

LilyWangL removed the requires:discussion label Jul 21, 2020

LilyWangL approved these changes Jul 21, 2020

View reviewed changes

c72578 mentioned this pull request Jul 25, 2020

bzip2 build failure #12567

Closed

elieux reviewed Jul 25, 2020

View reviewed changes

scripts/cmake/vcpkg_acquire_msys.cmake Outdated Show resolved Hide resolved

elieux reviewed Jul 25, 2020

View reviewed changes

[vcpkg-acquire-msys] Install new keyring

94144e9

emptyVoid force-pushed the fix-issue-12288 branch from 8451f3d to 94144e9 Compare July 26, 2020 14:21

yasamoka mentioned this pull request Jul 27, 2020

[vcpkg_acquire_msys] build failure with "error: failed to update mingw32/mingw64 (invalid or corrupted database (PGP signature))" #12584

Closed

JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jul 27, 2020

JackBoosY approved these changes Jul 27, 2020

View reviewed changes

JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 27, 2020

This was linked to issues Jul 27, 2020

[vcpkg_acquire_msys] build failure with "error: failed to update mingw32/mingw64 (invalid or corrupted database (PGP signature))" #12584

Closed

zlib:x64-windows build failure #12582

Closed

PhoebeHui mentioned this pull request Jul 27, 2020

zlib:x64-windows build failure #12582

Closed

traversaro mentioned this pull request Jul 27, 2020

Add boost-bind and libjpeg-turbo, bump vcpkg to commit from October 2020 and vendor custom port to avoid portaudio and ogre problem robotology/robotology-superbuild-dependencies-vcpkg#24

Merged

microsoft deleted a comment from azure-pipelines bot Jul 27, 2020

JackBoosY mentioned this pull request Jul 27, 2020

[boost] update/new install build failure #12593

Closed

JackBoosY linked an issue Jul 27, 2020 that may be closed by this pull request

[boost] update/new install build failure #12593

Closed

JackBoosY mentioned this pull request Jul 27, 2020

[protobuf:x64-windows] build failure #12594

Closed

JackBoosY linked an issue Jul 27, 2020 that may be closed by this pull request

[protobuf:x64-windows] build failure #12594

Closed

cenit mentioned this pull request Jul 28, 2020

[vcpkg msys] Fix msys2 #12603

Closed

strega-nil merged commit 25412e1 into microsoft:master Jul 28, 2020

emptyVoid deleted the fix-issue-12288 branch July 28, 2020 19:16

This was referenced Jul 29, 2020

[curlpp[core]:x86-windows] build failure #12598

Closed

[bzip2:x64-windows] build failure #12597

Closed

JackBoosY mentioned this pull request Jul 30, 2020

[zlib, protobuf, grpc, x86-windows, x64-windows] build failure #12618

Closed

maxGimeno mentioned this pull request Jul 30, 2020

Error when trying to install cgal[qt]:x64-windows through vcpkg CGAL/cgal#4890

Closed

olegshtch mentioned this pull request Jul 30, 2020

Appveyor failing Cockatrice/Cockatrice#4054

Closed

strega-nil mentioned this pull request Jul 30, 2020

[msys] use fresh msys, fix update core #11471

Closed

hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020

[vcpkg-acquire-msys] Install new keyring (microsoft#12467)

aaea2fc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vcpkg-acquire-msys] Install new keyring #12467

[vcpkg-acquire-msys] Install new keyring #12467

emptyVoid commented Jul 17, 2020

MVoz commented Jul 17, 2020 •

edited

Loading

elieux commented Jul 20, 2020

MVoz commented Jul 20, 2020 •

edited

Loading

elieux commented Jul 20, 2020

MVoz commented Jul 20, 2020

elieux commented Jul 20, 2020

MVoz commented Jul 20, 2020 •

edited

Loading

elieux commented Jul 20, 2020

MVoz commented Jul 21, 2020 •

edited

Loading

elieux commented Jul 24, 2020

yasamoka commented Jul 24, 2020 •

edited

Loading

coryan commented Jul 24, 2020

yasamoka commented Jul 25, 2020 •

edited

Loading

c72578 commented Jul 25, 2020

elieux Jul 25, 2020

emptyVoid Jul 26, 2020

elieux commented Jul 25, 2020 •

edited

Loading

MVoz commented Jul 26, 2020

emptyVoid commented Jul 26, 2020

MVoz commented Jul 26, 2020

c72578 commented Jul 26, 2020

JackBoosY commented Jul 27, 2020

azure-pipelines bot commented Jul 27, 2020

JackBoosY commented Jul 27, 2020

angelo-peronio commented Jul 28, 2020

yasamoka commented Jul 28, 2020 •

edited

Loading

strega-nil commented Jul 28, 2020

azure-pipelines bot commented Jul 28, 2020

[vcpkg-acquire-msys] Install new keyring #12467

[vcpkg-acquire-msys] Install new keyring #12467

Conversation

emptyVoid commented Jul 17, 2020

MVoz commented Jul 17, 2020 • edited Loading

elieux commented Jul 20, 2020

MVoz commented Jul 20, 2020 • edited Loading

elieux commented Jul 20, 2020

MVoz commented Jul 20, 2020

elieux commented Jul 20, 2020

MVoz commented Jul 20, 2020 • edited Loading

elieux commented Jul 20, 2020

MVoz commented Jul 21, 2020 • edited Loading

elieux commented Jul 24, 2020

yasamoka commented Jul 24, 2020 • edited Loading

coryan commented Jul 24, 2020

yasamoka commented Jul 25, 2020 • edited Loading

c72578 commented Jul 25, 2020

elieux Jul 25, 2020

Choose a reason for hiding this comment

emptyVoid Jul 26, 2020

Choose a reason for hiding this comment

elieux commented Jul 25, 2020 • edited Loading

MVoz commented Jul 26, 2020

emptyVoid commented Jul 26, 2020

MVoz commented Jul 26, 2020

c72578 commented Jul 26, 2020

JackBoosY commented Jul 27, 2020

azure-pipelines bot commented Jul 27, 2020

JackBoosY commented Jul 27, 2020

angelo-peronio commented Jul 28, 2020

yasamoka commented Jul 28, 2020 • edited Loading

strega-nil commented Jul 28, 2020

azure-pipelines bot commented Jul 28, 2020

MVoz commented Jul 17, 2020 •

edited

Loading

MVoz commented Jul 20, 2020 •

edited

Loading

MVoz commented Jul 20, 2020 •

edited

Loading

MVoz commented Jul 21, 2020 •

edited

Loading

yasamoka commented Jul 24, 2020 •

edited

Loading

yasamoka commented Jul 25, 2020 •

edited

Loading

elieux commented Jul 25, 2020 •

edited

Loading

yasamoka commented Jul 28, 2020 •

edited

Loading