Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt-webengine] Fix building with vs2017 #12494

Merged
merged 4 commits into from
Aug 1, 2020
Merged

[qt-webengine] Fix building with vs2017 #12494

merged 4 commits into from
Aug 1, 2020

Conversation

Neumann-A
Copy link
Contributor

closes #12477

@JackBoosY JackBoosY self-requested a review July 21, 2020 00:02
@JackBoosY JackBoosY self-assigned this Jul 21, 2020
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jul 21, 2020
Neumann-A
Neumann-A commented Jul 21, 2020
View reviewed changes
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@Neumann-A Neumann-A force-pushed the fix_qt_webengine_vs2017 branch from 8d8d33c to d6057fc Compare July 21, 2020 07:20
@Neumann-A Neumann-A force-pushed the fix_qt_webengine_vs2017 branch from d6057fc to 7aa64f9 Compare July 21, 2020 07:21
@JackBoosY
Copy link
Contributor 

[27846/28243] ninja -t msvc -e environment.x64 -- "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.26.28801\bin\HostX64\x64/cl.exe" /nologo /showIncludes "-DCHROMIUM_VERSION=\"80.0.3987.163\"" -DUSE_AURA=1 -DTOOLKIT_QT -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=2 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=NTDDI_WIN10_RS2 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DUNICODE -D_UNICODE -DWIN32 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -DWIN64 -DQT_NO_LINKED_LIST -DQT_NO_KEYWORDS -DQT_USE_QSTRINGBUILDER -DQ_FORWARD_DECLARE_OBJC_CLASS=QT_FORWARD_DECLARE_CLASS "-DQTWEBENGINECORE_VERSION_STR=\"5.15.0\"" "-DQTWEBENGINEPROCESS_NAME=\"QtWebEngineProcessd\"" -DBUILDING_CHROMIUM -DQT_NO_EXCEPTIONS -DQT_QUICK_LIB -DQT_GUI_LIB -DQT_QMLMODELS_LIB -DQT_WEBCHANNEL_LIB -DQT_QML_LIB -DQT_NETWORK_LIB -DQT_POSITIONING_LIB -DQT_CORE_LIB -DQT_WEBENGINECOREHEADERS_LIB -DWEBP_EXTERN=extern -DUSE_EGL -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=wchar_t -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_WIN -DABSL_ALLOCATOR_NOTHROW=1 -DWEBRTC_USE_BUILTIN_ISAC_FIX=0 -DWEBRTC_USE_BUILTIN_ISAC_FLOAT=1 -DHAVE_SCTP -DNO_MAIN_THREAD_WRAPPING -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY "-DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\"" -DSK_GL -DSK_HAS_JPEG_LIBRARY -DSK_USE_LIBGIFCODEC -DSK_SUPPORT_GPU=1 "-DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"" -DGR_GL_FUNCTION_TYPE=__stdcall -DLEVELDB_PLATFORM_CHROMIUM=1 -DLEVELDB_PLATFORM_CHROMIUM=1 -DV8_ENABLE_CHECKS -DV8_COMPRESS_POINTERS -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_DEPRECATION_WARNINGS -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/skia/config -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/boringssl/src/include -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/skia/include/core -Igen -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium -ID:/buildtrees/qt5-webengine/src/5.15.0-358d713a2a.clean/src/core -ID:/buildtrees/qt5-webengine/src/5.15.0-358d713a2a.clean/src/core/api -ID:/installed/x64-windows/include/QtQuick/5.15.0 -ID:/installed/x64-windows/include/QtQuick/5.15.0/QtQuick -ID:/installed/x64-windows/include/QtGui/5.15.0 -ID:/installed/x64-windows/include/QtGui/5.15.0/QtGui -ID:/installed/x64-windows/include -ID:/installed/x64-windows/include/QtQuick -ID:/installed/x64-windows/include/QtGui -ID:/installed/x64-windows/include/QtQmlModels/5.15.0 -ID:/installed/x64-windows/include/QtQmlModels/5.15.0/QtQmlModels -ID:/installed/x64-windows/include/QtQml/5.15.0 -ID:/installed/x64-windows/include/QtQml/5.15.0/QtQml -ID:/installed/x64-windows/include/QtCore/5.15.0 -ID:/installed/x64-windows/include/QtCore/5.15.0/QtCore -ID:/installed/x64-windows/include/QtQmlModels -ID:/installed/x64-windows/include/QtWebChannel -ID:/installed/x64-windows/include/QtQml -ID:/installed/x64-windows/include/QtNetwork -ID:/installed/x64-windows/include/QtPositioning -ID:/installed/x64-windows/include/QtCore -ID:/buildtrees/qt5-webengine/src/5.15.0-358d713a2a.clean/include -ID:/buildtrees/qt5-webengine/src/5.15.0-358d713a2a.clean/include/QtWebEngineCore -ID:/buildtrees/qt5-webengine/src/5.15.0-358d713a2a.clean/include/QtWebEngineCore/5.15.0 -ID:/buildtrees/qt5-webengine/src/5.15.0-358d713a2a.clean/include/QtWebEngineCore/5.15.0/QtWebEngineCore -ID:/buildtrees/qt5-webengine/x64-windows-dbg/include -ID:/buildtrees/qt5-webengine/x64-windows-dbg/include/QtWebEngineCore -ID:/buildtrees/qt5-webengine/x64-windows-dbg/include/QtWebEngineCore/5.15.0 -ID:/buildtrees/qt5-webengine/x64-windows-dbg/include/QtWebEngineCore/5.15.0/QtWebEngineCore -I.moc/debug -ID:/installed/x64-windows/include -Igen/.moc -ID:/installed/x64-windows/tools/qt5/debug/mkspecs/win32-msvc -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/libyuv/include -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/jsoncpp/source/include -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/jsoncpp/generated -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/libwebp/src -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/khronos -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/gpu -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/wtl/include -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/dawn/src/include -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/dawn/src/include -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/boringssl/src/include -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/protobuf/src -Igen/protoc_out -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/protobuf/src -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/ced/src -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/icu/source/common -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/icu/source/i18n -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/webrtc_overrides -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/webrtc -Igen/third_party/webrtc -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/abseil-cpp -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/skia -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/libgifcodec -Igen/third_party/perfetto -Igen/third_party/perfetto -Igen/third_party/perfetto -Igen/third_party/perfetto -Igen/third_party/perfetto -Igen/third_party/perfetto -Igen/third_party/perfetto -Igen/third_party/perfetto -Igen/third_party/perfetto -Igen/third_party/perfetto -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/libwebm/source -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/leveldatabase -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/leveldatabase/src -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/leveldatabase/src/include -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/v8/include -Igen/v8/include -I../../../../src/5.15.0-358d713a2a.clean/src/3rdparty/chromium/third_party/mesa_headers /Gy /FS /bigobj /utf-8 /Zc:sizedDealloc- /wd4117 /D__DATE__= /D__TIME__= /D__TIMESTAMP__= /W4 /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /wd4200 /wd4201 /wd4204 /wd4221 /wd4245 /wd4267 /wd4305 /wd4389 /wd4702 /wd4701 /wd4703 /wd4661 /wd4706 /wd4715 /Od /Ob0 /GF /Zi /MDd -nologo -Zc:wchar_t -FS -Zc:strictStrings -Zi -MDd -utf-8 -W3 -w44456 -w44457 -w44458 /wd4267 /TP /wd4577 -nologo -Zc:wchar_t -FS -Zc:rvalueCast -Zc:inline -Zc:strictStrings -Zc:throwingNew -Zc:referenceBinding -Zc:__cplusplus -Zi -MDd -std:c++14 -utf-8 /wd4530 /wd4577 -W3 -w34100 -w34189 -w44996 -w44456 -w44457 -w44458 -wd4577 -wd4467 /wd4100 /wd4101 /c D:/buildtrees/qt5-webengine/src/5.15.0-358d713a2a.clean/src/core/browser_message_filter_qt.cpp /Foobj/QtWebEngineCore/browser_message_filter_qt.obj /Fd"obj/QtWebEngineCore_cc.pdb"
FAILED: obj/QtWebEngineCore/browser_message_filter_qt.obj

@Neumann-A
Copy link
Contributor Author

@JackBoosY: Pasting the error is more helpful than the failed message:
D:\buildtrees\qt5-webengine\x64-windows-dbg\src\core\debug\gen\net/third_party/quiche/src/quic/core/proto/cached_network_parameters.pb.h(17): fatal error C1189: #error: This file was generated by an older version of protoc which is
The problem here is that protobuf seems to be installed in vcpkg. The qt solution is to remove protobuf and install qt-webengine before installing protobuf (https://cpplang.slack.com/archives/C29936TQC/p1592943928142000)
related #12150

@JackBoosY
Copy link
Contributor

@Neumann-A I want to add this port to pipeline pre-build list, but it takes much time. I had to choose other way.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 23, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

I want to rerun PR tests after #12529

@Neumann-A
Copy link
Contributor Author

@strega-nil: Rerunning CI will test nothing concering qt5-webengine since qt5-webengine is on the skiplist and cannot be built if protobuf is installed before qt5-webengine (which is the case in CI)

@strega-nil strega-nil merged commit f7dcd67 into microsoft:master Aug 1, 2020
@Neumann-A Neumann-A deleted the fix_qt_webengine_vs2017 branch August 17, 2020 19:13
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@Neumann-A @hellozee
[qt-webengine] Fix building with vs2017 (microsoft#12494)
56abdc5 
* [qt5-webengine] fix vs2017 builds. closes microsoft#12477

* remove skip from ci baseline to test changes.

* add src/3rdparty/ subdir to patch

* put webengine back to skip. patch was succesfully applied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[qt5-webengine] build failure
3 participants
@Neumann-A @JackBoosY @strega-nil