-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jthread] Initial port #12497
[jthread] Initial port #12497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a header-only library?
It seems that the repo is an unofficial website. Could you please use an official one?
Yes, this is a header only library. I don't understand what you mean about the unofficial website. jthread is an upcoming feature from the new C++20 standard not currently available in Visual Studio, which is why I made this port. It was proposed by Nicolai Josuttis and I'm using the repository where he submitted his implementation of it. From : https://medium.com/@vgasparyan1995/a-new-thread-in-c-20-jthread-ebd121ae8906
|
@RT222 Thanks for your detailed information. |
Co-authored-by: NancyLi1013 <[email protected]>
Co-authored-by: NancyLi1013 <[email protected]>
Co-authored-by: NancyLi1013 <[email protected]>
Given that there are two libraries named |
Isn't jthread for this one, and j0r1-jthread for the other one that you mentioned better? As the former is the implementation of the upcoming C++ 20 feature of the same name, I think it is the most appropriate candidate to be simply named jthread. |
Since this library is no more "official" than any other jthread library, it's totally reasonable for anyone to release a jthread library and call it jthread. Since that is the case, it makes more sense to me to namespace it with the author's name. |
I made the change you asked, but I still disagree with the "no more official" part, given that we are talking about the reference implementation of a standard C++ feature on a C++ package manager. :( |
@RT222 I get your opinion; thanks for listening anyways ❤️ |
* [jthread] Initial port https://github.com/josuttis/jthread * [jthread] Add header only comment Co-authored-by: NancyLi1013 <[email protected]> * [jthread] Fix version date Co-authored-by: NancyLi1013 <[email protected]> * [jthread] Move headers to include directory Co-authored-by: NancyLi1013 <[email protected]> * [jthread] Rename the port josuttis-jthread * [jthread] Fix control port name Co-authored-by: NancyLi1013 <[email protected]> Co-authored-by: Rémy Tassoux <[email protected]>
https://github.com/josuttis/jthread