Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sqlite3] Namespaced targets with unofficial:: #12516

Merged
merged 4 commits into from
Aug 5, 2020
Merged

[sqlite3] Namespaced targets with unofficial:: #12516

merged 4 commits into from
Aug 5, 2020

Conversation

PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Jul 21, 2020 •
edited
Loading

Fixes #12505

  1. Namespaced sqlite3 targets with unofficial::
  2. Update the ports(libgpod, libodb-sqlite, sqlitecpp) which depends on it.
  3. All features test pass with x86-windows.

@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label Jul 21, 2020
@PhoebeHui PhoebeHui mentioned this pull request Jul 21, 2020
Closed
@PhoebeHui PhoebeHui marked this pull request as ready for review July 23, 2020 01:21
@PhoebeHui PhoebeHui added the info:internal This PR or Issue was filed by the vcpkg team. label Jul 23, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 23, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui
Copy link
Contributor Author

PhoebeHui commented Jul 31, 2020 •
edited
Loading

We might need update related docs as well, I remember we has some example that use sqlite3.

https://github.com/microsoft/vcpkg/blob/f9bdf139535f25dd0847fecff22a1c8c606da613/docs/examples/installing-and-using-packages.md#cmake-toolchain-file

https://github.com/microsoft/vcpkg/blob/a5a244f5bdc390fc1c3d42e126e0bfd80541f060/docs/examples/overlay-triplets-linux-dynamic.md

https://vcpkg.readthedocs.io/en/latest/examples/installing-and-using-packages/

@PhoebeHui PhoebeHui marked this pull request as draft July 31, 2020 05:56
@strega-nil
Copy link
Contributor

@PhoebeHui could you look into that today and get back to me?

@PhoebeHui
Copy link
Contributor Author

Sure.

@PhoebeHui
Copy link
Contributor Author

@strega-nil, I have updated the example on github, could you help update the sqlite3 in doc https://vcpkg.readthedocs.io/en/latest/examples/installing-and-using-packages/

@strega-nil
Copy link
Contributor

@PhoebeHui is there a reason that this is a draft PR?

@PhoebeHui PhoebeHui marked this pull request as ready for review August 3, 2020 02:04
@PhoebeHui
Copy link
Contributor Author

@strega-nil, I usually mark it to 'ready to review' when the CI test pass.

@strega-nil strega-nil merged commit f3221c0 into microsoft:master Aug 5, 2020
@strega-nil
Copy link
Contributor

strega-nil commented Aug 5, 2020 •
edited
Loading

@PhoebeHui ah, cool, thanks ❤️

@PhoebeHui PhoebeHui deleted the dev/Phoebe/sqlite3 branch August 11, 2020 01:59
@stoperro
Copy link
Contributor

stoperro commented Sep 2, 2020

I think dlib port still references sqlite3 not unofficial-sqlite3 in: installed\x64-windows\share\dlib\dlibConfig.cmake:
find_dependency(sqlite3 CONFIG)

@PhoebeHui
Copy link
Contributor Author

@stoperro, thanks for reporting this issue, I sumiited PR #13325 to update it.

hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@PhoebeHui @hellozee
[sqlite3] Namespaced targets with unofficial:: (microsoft#12516)
c5f9862 
* [sqlite3] Namespaced targets with unofficial::

* Fix failure ports

* Update the targets name

* Update related docs
@hebasto hebasto mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SQlite3] Missing unofficial:: namespace in generated target.
5 participants
@PhoebeHui @strega-nil @stoperro @Neumann-A @JackBoosY