[ngspice] Initial port #12695
Merged
[ngspice] Initial port #12695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NancyLi1013
added
the
category:new-port
NancyLi1013
suggested changes
Aug 3, 2020
NancyLi1013
suggested changes
Aug 3, 2020
|
@NancyLi1013 I applied your suggest changes but it appears CI is ignoring the !static flag and building it and failing anyway? Edit: Added !uwp as well, it seems to respect that flag but it's still ignoring !static. |
NancyLi1013
suggested changes
Aug 4, 2020
|
@NancyLi1013 Now it built windows static and OSX regardless of the supports flags :/ |
|
@marekr So please remove it from supports list and we still need to add |
NancyLi1013
suggested changes
Aug 4, 2020
Add the msvc specific include folder to be copied as well Fix 32-bit builds Use install_msbuild Remove fftw Fix 32-bit build again Update ci baseline and check linkage for dll only Use spaces consistently More clean Update ports/ngspice/CONTROL Co-authored-by: NancyLi1013 <[email protected]> Update ports/ngspice/portfile.cmake Co-authored-by: NancyLi1013 <[email protected]> Update ports/ngspice/portfile.cmake Co-authored-by: NancyLi1013 <[email protected]> Update ports/ngspice/portfile.cmake Co-authored-by: NancyLi1013 <[email protected]> Update scripts/ci.baseline.txt Co-authored-by: NancyLi1013 <[email protected]> remove uwp support Update ports/ngspice/CONTROL Co-authored-by: NancyLi1013 <[email protected]>
Co-authored-by: NancyLi1013 <[email protected]>
|
@NancyLi1013 No worries :D Applied static to the baseline fail. |
NancyLi1013
approved these changes
Aug 5, 2020
NancyLi1013
added
info:reviewed
hellozee
pushed a commit
to hellozee/vcpkg
that referenced
this pull request
Sep 11, 2020
* Add ngspice port Add the msvc specific include folder to be copied as well Fix 32-bit builds Use install_msbuild Remove fftw Fix 32-bit build again Update ci baseline and check linkage for dll only Use spaces consistently More clean Update ports/ngspice/CONTROL Co-authored-by: NancyLi1013 <[email protected]> Update ports/ngspice/portfile.cmake Co-authored-by: NancyLi1013 <[email protected]> Update ports/ngspice/portfile.cmake Co-authored-by: NancyLi1013 <[email protected]> Update ports/ngspice/portfile.cmake Co-authored-by: NancyLi1013 <[email protected]> Update scripts/ci.baseline.txt Co-authored-by: NancyLi1013 <[email protected]> remove uwp support Update ports/ngspice/CONTROL Co-authored-by: NancyLi1013 <[email protected]> * Update ports/ngspice/portfile.cmake Co-authored-by: NancyLi1013 <[email protected]> * Use the suggest supports Co-authored-by: NancyLi1013 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ngspice, an actively maintained open source SPICE (circuit simulator) as a shared library build for Windows.
This is currently only compatible with x86 and x64 for Windows as those are the only upstream supported arches for Windows (for now)