Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[constexpr-contracts] Adds new port #12818

Merged
merged 3 commits into from
Aug 13, 2020

Conversation

cjdb
Copy link
Contributor

@cjdb cjdb commented Aug 8, 2020

Describe the pull request

adds constexpr-contracts to vcpkg

What does your PR fix?

Fixes #11578

Which triplets are supported/not supported? Have you updated the CI baseline?

All triplets should be supported if the compilers used are recent enough.

Does your PR follow the maintainer guide?

Make separate Pull Requests per port

Yes.

Avoid trivial changes in untouched files

Yes.

Check names against other repositories

constexpr-contracts not currently identified by Repology.

c000001: No deprecated helper functions are used

No.

c000002: Control Version field is updated

Yes.

c000003: New ports contain a Description field written in English

Yes.

c000004: No unnecessary comments are present in the changeset

No.

c000005: Downloaded archives are versioned if available

Unsure.

c000006: New ports pass CI checks for triplets that the library officially supports

Should be in progress upon PR submission.

c000007: Patches fix issues that are vcpkg-specific only

Yes.

c000008: New ports download source code from the official source if available

I am the source author and can confirm this is true.

c000010: Ports and port features are named correctly

Yes.

c000011: Library targets are exported when appropriate

Unsure.

c000012: Ports do not use applications which modify the user's system

Yes.

c000013: Ports with system dependencies include an information message during installation

No dependencies beyond a C++20 compiler.

@cjdb cjdb force-pushed the constexpr-contracts branch from 5f7f0fd to f733d36 Compare August 8, 2020 19:59
@cjdb cjdb marked this pull request as draft August 8, 2020 20:17
@cjdb cjdb force-pushed the constexpr-contracts branch 2 times, most recently from 066c5e7 to c76ec14 Compare August 8, 2020 20:28
@cjdb cjdb marked this pull request as ready for review August 8, 2020 20:28
@cjdb cjdb force-pushed the constexpr-contracts branch from c76ec14 to 3052c4e Compare August 8, 2020 20:34
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 10, 2020
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 10, 2020
Copy link
Contributor

@ras0219 ras0219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit e1a0367 into microsoft:master Aug 13, 2020
remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
* adds constexpr-contracts to vcpkg

* Update ports/constexpr-contracts/CONTROL

Co-authored-by: NancyLi1013 <[email protected]>

* Apply suggestions from code review

Co-authored-by: ras0219 <[email protected]>

Co-authored-by: NancyLi1013 <[email protected]>
Co-authored-by: nicole mazzuca <[email protected]>
Co-authored-by: ras0219 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] constexpr-contracts
4 participants