Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[many ports] Add supports #12857

Merged
merged 7 commits into from
Sep 3, 2020
Merged

[many ports] Add supports #12857

merged 7 commits into from
Sep 3, 2020

Conversation

PhoebeHui
Copy link
Contributor

Closes #12390 #12830 #11277 (comment)

Add unsupport arch/target to 'Support".

@PhoebeHui PhoebeHui added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Aug 11, 2020
@Neumann-A
Copy link
Contributor

Add unsupport arch/target to 'Support".

@ras0219 @ras0219-msft @strega-nil : I think the Supports field should only be used if a port is not designed to be used on a specific platform and not mean vcpkg is just not currently able to build the port on that platform. Maybe a clear guideline when /how to use the Supports field is required.

@JackBoosY JackBoosY mentioned this pull request Aug 12, 2020
Merged
@BillyONeal BillyONeal self-assigned this Aug 20, 2020
@BillyONeal
Copy link
Member

We had an IRL discussion about this on Thursday. The results of that were:

  • The Supports field is primarily intended to avoid folks needing to waste time building stuff that we know will be broken. To that end, it is an artifact of the port, not of the package, so if the port we have is unable to target a platform it doesn't matter what the package supports.
  • The Supports field is not an artifact of our CI system, so if a port works locally but is broken in our CI system for some reason (e.g. conflicts with another port in a way we accept like boringssl, depends on some dependency already being installed we can't install there for some reason, etc) that goes in ci.baseline.txt, not Supports.

I believe this change is in keeping with those terms and thus good.

@BillyONeal
Merge remote-tracking branch 'origin/master' into dev/Phoebe/add_supp…
38a6b9d 
…orts

# Conflicts:
#	ports/speex/CONTROL
#	ports/speex/portfile.cmake
@PhoebeHui
Copy link
Contributor Author

The I have added the !static to Supports for the 2 ports, however, it doesn't skip in CI, still failed here.

REGRESSION: alembic:x64-windows-static. If expected, add alembic:x64-windows-static=fail to .\scripts\ci.baseline.txt.
REGRESSION: avisynthplus:x64-windows-static. If expected, add avisynthplus:x64-windows-static=fail to .\scripts\ci.baseline.txt.

@BillyONeal
Copy link
Member

The I have added the !static to Supports for the 2 ports, however, it doesn't skip in CI, still failed here.

vcpkg ci x64-windows-static for some reason isn't turning on the "static" flag when evaluating "supports" expressions. :(

@BillyONeal BillyONeal merged commit e7dc93f into microsoft:master Sep 3, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@PhoebeHui PhoebeHui deleted the dev/Phoebe/add_supports branch October 22, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL LilyWangL approved these changes

@strega-nil strega-nil strega-nil approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@BillyONeal BillyONeal

@LilyWangL LilyWangL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vcpkg install atkmm error
5 participants
@PhoebeHui @Neumann-A @BillyONeal @strega-nil @LilyWangL