Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding meson-build to the linux VM provisioning script #12858

Closed
wants to merge 1 commit into from
Closed

adding meson-build to the linux VM provisioning script #12858

wants to merge 1 commit into from

Conversation

marzer
Copy link
Contributor

@marzer marzer commented Aug 11, 2020

This PR is an exact replay of #12224, but from a branch other than master. See the discussion on that PR for context etc.

A number of minor things relating to the use of the meson build system:

  • Adds a step to the x64-linux provisioning script to install meson 0.54.3
  • Fixes vcpkg_find_acquire_program suggesting that linux users use apt to install meson, instead of pip3
  • Updates vcpkg_find_acquire_program meson version to 0.54.3
  • Updates ports/tool-meson/CONTROL version to 0.54.3

What does your PR fix?
Doesn't fix, but contributes to, the resolution of #10786. A quick search of the issues for meson suggests that it would be useful for a number of others, too.

Which triplets are supported/not supported? Have you updated the CI baseline?
I don't think this question is relevant to my change, since I'm not submitting a port.

Does your PR follow the maintainer guide?
I believe so.

also:
- updated meson version in `vcpkg_find_acquire_program` to 0.54.3
- added a `PIP3_PACKAGE_NAME` option to the `vcpkg_find_acquire_program` help message generator
- updated `ports/tool-meson/CONTROL` version to 0.54.3
@Neumann-A
Copy link
Contributor

as said previously we cannot rely on the system package manager for meson due to it being to low in version. As soon as meson hits 0.55.1 i will continue #12393 which will simply download the version specified by vcpkg and use that instead of system provided meson.

@marzer
Copy link
Contributor Author

marzer commented Aug 11, 2020

@Neumann-A

as said previously

Where? am I supposed to know what you're talking about?

Are you saying that this PR isn't necessary then? If so, I'm happy to close it. I don't really want to maintain this.

@Neumann-A
Copy link
Contributor

Where? am I supposed to know what you're talking about?

see discussion in #12224.

Are you saying that this PR isn't necessary then? If so, I'm happy to close it. I don't really want to maintain this.

according to the discussion in #12224 (comment) I would say yes since we will use a different approach to fix the meson version in the future.

@marzer
Copy link
Contributor Author

marzer commented Aug 11, 2020

None of your points in that PR suggest that, except maybe the one about vcpkg_find_acquire_program, but that's actually addressed by this PR. You need to provide more information.

@marzer
Copy link
Contributor Author

marzer commented Aug 11, 2020

Actually, never mind. If your PR brings meson up to a newer version, then I don't really care much for the details ^_^

@marzer marzer closed this Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants