-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Fix build on older compilers. #12950
Conversation
Signed-off-by: Hans <[email protected]>
Hi @huahang; could you specifically mention which compiler versions this change enables? We also require the C++ Filesystem TS which imposes an additional minimum requirement. |
The specific compiler I am using is clang-7 in debian 9. C++ Filesystem TS works fine. It just lacks support of The command I use to build vcpkg is: |
@ras0219 @JackBoosY |
Thanks for your contribution! |
Describe the pull request
What does your PR fix? Fixes #
std::is_const_v
andstd::is_reference_v
are introduced in c++17, not available when using older compilers. This change replaces them withstd::is_const<T>::value
andstd::is_reference<T>::value
.Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?
Signed-off-by: Hans [email protected]