Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fluidsynth/redis-plus-plus] Update to the latest released version #12974

Merged

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Fixes fluidsynth build failure #12968

  • Update fluidsynth to latest version 2.1.4.

  • Use vcpkg_copy_tools to fix the tools cannot be found on unix.

Also update redis-plus-plus to latest version 1.1.2 and fix typo error.

Note: No features need to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Aug 18, 2020
@BillyONeal
Copy link
Member

This looks good to me, any reason it's still draft?

@NancyLi1013 NancyLi1013 marked this pull request as ready for review August 19, 2020 01:41
@NancyLi1013
Copy link
Contributor Author

Just to wait for CI test results. It seems work fine now.
So I convert it to open. Thanks for your reminder @BillyONeal

@NancyLi1013
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal merged commit 2f9d4a1 into microsoft:master Aug 20, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fluidsynth build failure
3 participants