Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libhsplasma] Add new port #13174

Merged
merged 6 commits into from
Sep 1, 2020
Merged

[libhsplasma] Add new port #13174

merged 6 commits into from
Sep 1, 2020

Conversation

Hoikas
Copy link
Contributor

@Hoikas Hoikas commented Aug 27, 2020

This adds a port for libHSPlasma.

@Hoikas Hoikas marked this pull request as draft August 27, 2020 02:46
@Hoikas
Copy link
Contributor Author

Hoikas commented Aug 27, 2020

I'm converting this to a draft in order to deal with CI failures and an issue with HSPlasma_INCLUDE_DIRS, which may require an update to the upstream library.

@JackBoosY
Copy link
Contributor

Failure logs here.

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 27, 2020
@Hoikas Hoikas mentioned this pull request Aug 27, 2020
Merged
@Hoikas
Copy link
Contributor Author

Hoikas commented Aug 27, 2020

Blocking on upstream H-uru/libhsplasma#184, which should fix the CI issues.

@Hoikas Hoikas marked this pull request as ready for review August 30, 2020 18:59
@Hoikas
Copy link
Contributor Author

Hoikas commented Aug 30, 2020

Thanks for your patience @JackBoosY. This is now ready for your review.

JackBoosY
JackBoosY suggested changes Aug 31, 2020
View reviewed changes
@JackBoosY JackBoosY added requires:testing Needs tests added before merging requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function info:reviewed Pull Request changes follow basic guidelines and removed requires:testing Needs tests added before merging requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Aug 31, 2020
@JackBoosY
Copy link
Contributor

Test feautres successful on x86-windows and x64-windows.

@JackBoosY JackBoosY changed the title [libhsplasma] Add new port. [libhsplasma] Add new port Aug 31, 2020
@BillyONeal BillyONeal merged commit adc1719 into microsoft:master Sep 1, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hoikas @JackBoosY @BillyONeal