[vcpkg_from_sourceforge] Determine sourceforge status #13176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
info:internal
PhoebeHui
reviewed
Aug 28, 2020
Comment on lines
-62
to
-64
| if(vcpkg_download_distfile_SKIP_SHA512 AND NOT VCPKG_USE_HEAD_VERSION) | ||
| message(FATAL_ERROR "vcpkg_download_distfile only allows SKIP_SHA512 when building with --head") | ||
| endif() |
There was a problem hiding this comment.
Why do you remove this check?
There was a problem hiding this comment.
vcpkg_download_distfile(ARCHIVE
URLS "${DOWNLOAD_URL}"
SHA512 "${_vdus_SHA512}"
SKIP_SHA512
FILENAME "${_vdus_FILENAME}"
SILENT_EXIT
)
Here, since the file returned from sourceforge may be a web page in this case, it causes the inconsistency of SHA512, so we must skip the hash detection. This behavior was affected here, so it was deleted.
There was a problem hiding this comment.
This makes sense to me. @ras0219 @strega-nil @dan-shaw @vicroms Do you agree?
There was a problem hiding this comment.
I'm going to merge this since it's causing other PR validations to fail e.g. #11290 if folks don't want this change please let me know afterwards.
BillyONeal
approved these changes
Aug 28, 2020
Comment on lines
-62
to
-64
| if(vcpkg_download_distfile_SKIP_SHA512 AND NOT VCPKG_USE_HEAD_VERSION) | ||
| message(FATAL_ERROR "vcpkg_download_distfile only allows SKIP_SHA512 when building with --head") | ||
| endif() |
There was a problem hiding this comment.
This makes sense to me. @ras0219 @strega-nil @dan-shaw @vicroms Do you agree?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are some problems inside the sourceforge website, the downloaded file will become a web page with the content
We're sorry -- the Sourceforge site is currently in Disaster Recovery mode. Please check back later..Add code to deal with this situation.
Note: this PR cannot completely solve this problem, but it can handle incorrect HASH value judgments caused by changes in download content.