-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] improve s390x support #13386
Conversation
@lebdron, could you format the C++ file? The formatting of the C++ files didn't match our expectation. |
Signed-off-by: Andrei Lebedev <[email protected]>
e0370b5
to
8c4b4c2
Compare
@PhoebeHui Done, thanks! I would also suggest to specify in documentation which version of clang-format is used for CI, because clang-format-7 and clang-format-10 may have different outputs, for example. I see that "Install llvm clang-format" link points to version 10.0, but that is not that obvious in my opinion. |
@lebdron, clang-format-7 and clang-format-10 should be okay, we defined the format in https://github.com/microsoft/vcpkg/blob/master/toolsrc/.clang-format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR!
@dan-shaw, could you help furhter review?
LGTM, really cool to see further improvements here :) |
Signed-off-by: Andrei Lebedev <[email protected]>
Improve s390x support based on #11880
vcpkgUseSystem
in bootstrap.shVCPKG_FORCE_SYSTEM_BINARIES