[vcpkg] Merge the vcpkg metadata uploader into the vcpkg binary #13421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat we need sign only one binary.
BillyONeal
added
category:vcpkg-feature
strega-nil
reviewed
Sep 9, 2020
strega-nil
reviewed
Sep 9, 2020
ras0219-msft
approved these changes
Sep 9, 2020
| @@ -469,6 +469,8 @@ namespace vcpkg | |||
| STARTUPINFOW startup_info; | |||
| memset(&startup_info, 0, sizeof(STARTUPINFOW)); | |||
| startup_info.cb = sizeof(STARTUPINFOW); | |||
| startup_info.dwFlags = STARTF_USESHOWWINDOW; | |||
| startup_info.wShowWindow = SW_HIDE; | |||
There was a problem hiding this comment.
Do we always want these flags?
There was a problem hiding this comment.
I think we do but the bits could be renamed to be clearer, will fix.
There was a problem hiding this comment.
Does my rename resolve your concern?
| Commands::Version::VersionCommand version{}; | ||
| } | ||
| template<class CommandListT, size_t ExpectedCount> | ||
| void check_all_commands(const CommandListT& actual_commands, const char* const (&expected_commands)[ExpectedCount]) |
There was a problem hiding this comment.
Suggestion: take std::initializer_list<StringLiteral> as the second argument.
There was a problem hiding this comment.
I don't think that's an improvement: initializer_list exists to be the thing that controls constructor overload resolution; using it for any other purpose just encourages use after free bugs when people treat it like a container instead of a pointer to a temporary array.
ras0219
approved these changes
Sep 10, 2020
| @@ -469,6 +469,8 @@ namespace vcpkg | |||
| STARTUPINFOW startup_info; | |||
| memset(&startup_info, 0, sizeof(STARTUPINFOW)); | |||
| startup_info.cb = sizeof(STARTUPINFOW); | |||
| startup_info.dwFlags = STARTF_USESHOWWINDOW; | |||
| startup_info.wShowWindow = SW_HIDE; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, so that we need sign only one binary.