Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apr-util] use find_package(expat) #13663

Merged

Conversation

janholt
Copy link
Contributor

@janholt janholt commented Sep 22, 2020

apr-util finds expat by find_library(XMLLIB_LIBRARIES NAMES libexpat libexpatMD), but expat debug library has name libexpatd.lib. So apt-util debug configuration gets release expat. This PR fixes it.
Fixes #13582

@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 23, 2020
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 23, 2020
@ras0219-msft ras0219-msft merged commit 5c37337 into microsoft:master Sep 24, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

building against apr-util:x64-windows, libexpat.dll is not found when running the program
3 participants