[sdl2] Fix build when VCPKG_BUILD_TYPE is set to "release" #13801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
approved these changes
Sep 29, 2020
JackBoosY
added
category:port-bug
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@JackBoosY @dan-shaw The errors I'm seeing in CI do not appear to be released to this PR? |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
@past-due Our CI has been unstable and we are trying to get it fixed |
past-due
force-pushed
the
2020_fix_sdl2_build_type_release
branch
from
e983ee2 to
cf34c75
Compare
|
I've rebased this PR on latest master, and converted the Would it be possible to get this merged soon? (I'm having some unrelated issues with vcpkg's "overlay ports" feature I'm trying to track down, so it would be nice to get this merged and unblocking of our CI.) |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Oct 8, 2020
[sdl2] Fix build when VCPKG_BUILD_TYPE is set to "release" (microsoft#13801)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Fix
sdl2port build whenVCPKG_BUILD_TYPEis set toreleaseFixes #13800
No changes to support.