Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg/configure_cmake] add LOGNAME option #14002

Merged
merged 2 commits into from
Oct 15, 2020
Merged

[vcpkg/configure_cmake] add LOGNAME option #14002

merged 2 commits into from
Oct 15, 2020

Conversation

Neumann-A
Copy link
Contributor

preparation for #12936

@Neumann-A Neumann-A mentioned this pull request Oct 12, 2020
Merged
@PhoebeHui PhoebeHui self-assigned this Oct 13, 2020
@PhoebeHui PhoebeHui added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Oct 13, 2020
PhoebeHui
PhoebeHui approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!

@PhoebeHui PhoebeHui added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly and removed category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed labels Oct 13, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@PhoebeHui
Copy link
Contributor

PhoebeHui commented Oct 14, 2020 •
edited
Loading

The openxr_loader:x64-windows-static and openxr_loader:x64-linux failed with the following failures:

CMake Error: install(EXPORT "openxr_loader_export" ...) includes target "openxr_loader" which requires target "jsoncpp_interface" that is not in any export set.
CMake Error in src/loader/CMakeLists.txt:
export called with target "openxr_loader" which requires target
"jsoncpp_interface" that is not in any export set.

It's not related to this PR. It would be fixed by PR #14028

@PhoebeHui PhoebeHui mentioned this pull request Oct 14, 2020
Merged
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

I'll merge this after all the non-osx stuff passes, since we just deleted the osx archives

@PhoebeHui
Copy link
Contributor

@strega-nil , all the non-osx triplet passed. ready to merge.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Oct 15, 2020
@strega-nil strega-nil merged commit f919a1b into microsoft:master Oct 15, 2020
@Neumann-A Neumann-A deleted the configure_cmake_add_logname branch October 15, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neumann-A @strega-nil @PhoebeHui